Skip to content

Allow switching language in wiki#38174

Closed
MingxuanGame wants to merge 4 commits into
ppy:masterfrom
MingxuanGame:feat/switch-lang-in-wiki
Closed

Allow switching language in wiki#38174
MingxuanGame wants to merge 4 commits into
ppy:masterfrom
MingxuanGame:feat/switch-lang-in-wiki

Conversation

@MingxuanGame

Copy link
Copy Markdown
osu_2026-06-27_19-52-10 osu_2026-06-27_19-55-41

Comment thread osu.Game/Overlays/Wiki/Markdown/WikiNoticeContainer.cs Fixed
Comment thread osu.Game/Overlays/Wiki/WikiHeader.cs Fixed
@peppy

peppy commented Jun 28, 2026

Copy link
Copy Markdown
Member

This is LLM generated isn't it?

@MingxuanGame

Copy link
Copy Markdown
Author

This is LLM generated isn't it?

UI was assisted. logic is hand-written

@gagahpangeran

gagahpangeran commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

I compare with the previous attempt of this PR on #35024 (which is still open). This PR basically the same as that.

The difference is the implementation of the dropdown UI part. I assume this is the part of the code that is LLM assisted as you said before.

Reading that part of the code is a bit confusing, at least for me. Why is there so many complicated logic for this dropdown? For example, what's the purpose of syncExternalToDropdown() and suppressCurrentPropagation in the dropdown? And also there is no any explanation about that.

@peppy peppy closed this Jun 29, 2026
@peppy

peppy commented Jun 29, 2026

Copy link
Copy Markdown
Member

Let's just leave the previuos attempt open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants