Allow switching language in wiki#38174
Closed
MingxuanGame wants to merge 4 commits into
Closed
Conversation
MingxuanGame
commented
Jun 28, 2026
- Maybe duplicated of Add a dropdown menu to switch wiki content language #35024
- Unbind between wiki language and game language
- Add fallback notice when no translation
- Add outdated translation notice
Member
|
This is LLM generated isn't it? |
Author
UI was assisted. logic is hand-written |
Contributor
|
I compare with the previous attempt of this PR on #35024 (which is still open). This PR basically the same as that. The difference is the implementation of the dropdown UI part. I assume this is the part of the code that is LLM assisted as you said before. Reading that part of the code is a bit confusing, at least for me. Why is there so many complicated logic for this dropdown? For example, what's the purpose of |
Member
|
Let's just leave the previuos attempt open. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.