Add /watch chat command#38152
Open
jotkauser wants to merge 2 commits into
Open
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
bdach
reviewed
Jun 25, 2026
bdach
left a comment
bdach
left a comment
Collaborator
There was a problem hiding this comment.
Aside from the code quality inspection that needs to be fixed:
| var request = new GetUserRequest(username); | ||
| request.Success += user => | ||
| { | ||
| performer.PerformFromScreen(s => s.Push(new SoloSpectatorScreen(user))); |
Collaborator
There was a problem hiding this comment.
On stable, the command also fails if the user is not online. Technically this could be achieved via MetadataClient via something like
IDisposable? token = null;
if (!IsWatchingUserPresence)
token = BeginWatchingUserPresence();
var status = GetPresence(userId)?.Status;
token?.Dispose();
if (status != Online) Fail();I'm just not sure that it should be because this will work fine without it, by showing the spectator splash screen with the user card on it showing that the user is offline.
@peppy your opinion on how to proceed here please.
bdach
added
area:overlay-chat
subjective
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've noticed that there's no /watch chat command, but this command exists in stable, so i decided to add it here into lazer.