Fix stutter while closing settings overlay#38116
Closed
diquoks wants to merge 2 commits into
Closed
Conversation
diquoks
commented
Jun 19, 2026
diquoks
commented
Contributor
- closes The settings closing transition is not completely smooth #26572
bdach
added
type/cosmetic
bdach
reviewed
Jun 25, 2026
Comment on lines
+202
to
+204
| // Required for the transformation to be completed correctly, though the panel will be hidden earlier | ||
| AlwaysPresent = true; | ||
| Scheduler.AddDelayed(() => AlwaysPresent = false, TRANSITION_LENGTH); |
Collaborator
There was a problem hiding this comment.
I would rather not play AlwaysPresent games, especially with the settings overlay which is one of the heaviest in terms of drawable count.
Abstain from review. As #26572 (comment) says, the nicest conclusion would be actually tweaking the transforms not to do this. cc @peppy
bdach
added
the
subjective
Contributor
Author
|
as bdach explained in #38116 (comment), i think it would be easier and safer to make changes to the transition than to use this method |
bdach
pushed a commit
that referenced
this pull request
Jul 6, 2026
0xAlexisSys
pushed a commit
to 0xAlexisSys/osu
that referenced
this pull request
Jul 7, 2026
…ppy#38229) Closes ppy#26572. Alternative to ppy#38116.
0xAlexisSys
pushed a commit
to 0xAlexisSys/osu
that referenced
this pull request
Jul 7, 2026
…ppy#38229) Closes ppy#26572. Alternative to ppy#38116.
0xAlexisSys
pushed a commit
to 0xAlexisSys/osu
that referenced
this pull request
Jul 8, 2026
…ppy#38229) Closes ppy#26572. Alternative to ppy#38116.
0xAlexisSys
pushed a commit
to 0xAlexisSys/osu
that referenced
this pull request
Jul 9, 2026
…ppy#38229) Closes ppy#26572. Alternative to ppy#38116.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.