Make Target Practice incompatible with Grow and Deflate#38062
Open
AndiTafel wants to merge 2 commits into
Open
Make Target Practice incompatible with Grow and Deflate#38062AndiTafel wants to merge 2 commits into
AndiTafel wants to merge 2 commits into
Conversation
bdach
added
area:mods
subjective
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Target Practice already makes hit circles grow as they fade in, so I don't think being able to use TPGR or TPDF makes sense. (TPDF cancels out the grow effect and replaces it with the deflate animation.)
In fact, there is a class
OsuModObjectScaleTweenfor mods which adjust the size of hit objects during their fade in animation. At first I thoughtOsuModTargetPracticeshould inherit from this, as it is a mod which does that, but then it would have to have a Starting Size setting and be a Fun mod and I guess thats not intended.So instead I just made
OsuModTargetPracticeandOsuModObjectScaleTweenincompatible (OsuModGrowandOsuModDeflateare (currently) the only subclasses ofOsuModObjectScaleTween).