Skip to content

Added display for total time in queue for Ranked Play#37712

Merged
peppy merged 9 commits into
ppy:masterfrom
pacowoc:rp-visible-queue-time
Jun 27, 2026
Merged

Added display for total time in queue for Ranked Play#37712
peppy merged 9 commits into
ppy:masterfrom
pacowoc:rp-visible-queue-time

Conversation

@pacowoc

@pacowoc pacowoc commented May 11, 2026

Copy link
Copy Markdown
Contributor

Added a timer on the queue screen that shows the total time in queue for the player.
image

Comment thread osu.Game/Screens/OnlinePlay/Matchmaking/Queue/ScreenQueue.cs Fixed
Comment thread osu.Game/Screens/OnlinePlay/Matchmaking/Queue/ScreenQueue.cs Fixed
Comment thread osu.Game/Screens/OnlinePlay/Matchmaking/Queue/ScreenQueue.cs Fixed
@pacowoc pacowoc marked this pull request as ready for review May 11, 2026 18:26
Comment thread osu.Game/Screens/OnlinePlay/Matchmaking/Queue/ScreenQueue.cs Fixed
@peppy

peppy commented May 12, 2026

Copy link
Copy Markdown
Member

This looks weird as hell. Definitely shouldn't just be plonked on the end of the existing string.

Would prefer you open issues for design/UX proposals rather than PRs like this.

@pacowoc

pacowoc commented May 12, 2026

Copy link
Copy Markdown
Contributor Author

This looks weird as hell. Definitely shouldn't just be plonked on the end of the existing string.

Would prefer you open issues for design/UX proposals rather than PRs like this.

I just don’t find it weird personally,I find making another Text for this more clutter than just this

@bdach bdach requested a review from smoogipoo June 9, 2026 10:16
@pull-request-size pull-request-size Bot added size/M and removed size/S labels Jun 26, 2026
@smoogipoo

Copy link
Copy Markdown
Contributor

Moved it onto a separate line as requested:

image

@smoogipoo smoogipoo requested a review from peppy June 26, 2026 04:47
@nagi-desuuu

Copy link
Copy Markdown

Isn't the timer so small to be read correctly?

@pacowoc

pacowoc commented Jun 27, 2026

Copy link
Copy Markdown
Contributor Author

Isn't the timer so small to be read correctly?

I also think it is a little bit too small, I can change it but I am not sure which size is optimal

@peppy peppy merged commit cd6cd46 into ppy:master Jun 27, 2026
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants