feat: add Buffer and Threshold sliders for Skip Silence on Android - #357
Open
danieljrich wants to merge 1 commit into
Open
feat: add Buffer and Threshold sliders for Skip Silence on Android#357danieljrich wants to merge 1 commit into
danieljrich wants to merge 1 commit into
Conversation
…silence (Android)
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #364
Summary
Adds configurable Buffer (padding) and Threshold (dB cutoff) sliders when Skip Silence is enabled on Android.
Why
The default ExoPlayer 20 ms silence padding was cutting off word-initial unvoiced consonants (s, th, f, p) and trailing syllables on some audiobooks. Allowing users to adjust the buffer (0–200 ms, default 20 ms) and threshold (-50 to -20 dB, default -30 dB) resolves word clipping while keeping silence skipping fast and natural.
Key Changes
AbsorbSilenceAudioProcessor) delegating directly to Media3'sSilenceSkippingAudioProcessorwith on-the-fly parameter updates.AbsorbSilenceControllermirroring the establishedMonoControllerpattern._EffectRowin the Equalizer sheet with default position indicator tick marks:0 ms – 200 ms(default:20 ms)-50 dB – -20 dB(default:-30 dB)Testing
skip_silence_demo.mp4