fix: prevent file name collisions for multi disc audio books - #316
Open
schummar wants to merge 1 commit into
Open
fix: prevent file name collisions for multi disc audio books#316schummar wants to merge 1 commit into
schummar wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audio books can be separated into multiple disc folders, which contain non unique file names - e.g. "Track 01.mp3". (See https://audiobookshelf.org/docs/documentation/libraries/book-library/directory-structure#audiobook-tracks)
At the moment these files overwrite each other and unexpected content is played when you try to listen to the audio book.
This PR prefixes the files to prevent such collisions.
Btw. the download notifications are also broken in this scenario, but since this is a separate, if related, problem I wanted to first fix this and later have a look at the latter.