Agent 1 v2 review of MAST PR #25 noted: the new core1_rd_data stability test depends on an implicit guarantee that cm_rd_data (driven by global_mem_axi4_adapter) holds its value until the next request. No written contract exists in global_mem_axi4_adapter.sv. A multi-outstanding adapter or response-forwarding optimization could silently glitch this. Add: (a) header comment block in global_mem_axi4_adapter.sv documenting the invariant, (b) cocotb assertion in verif/global_mem_axi4_adapter/ that drives back-to-back reads with bus idle in between and asserts core_mem_rd_data is stable. Refs: MAST PR #25, PR #19. Authored by Agent R (Reviewer).
Agent 1 v2 review of MAST PR #25 noted: the new core1_rd_data stability test depends on an implicit guarantee that cm_rd_data (driven by global_mem_axi4_adapter) holds its value until the next request. No written contract exists in global_mem_axi4_adapter.sv. A multi-outstanding adapter or response-forwarding optimization could silently glitch this. Add: (a) header comment block in global_mem_axi4_adapter.sv documenting the invariant, (b) cocotb assertion in verif/global_mem_axi4_adapter/ that drives back-to-back reads with bus idle in between and asserts core_mem_rd_data is stable. Refs: MAST PR #25, PR #19. Authored by Agent R (Reviewer).