Repository navigation
Merge upstream and resolve PR #45 conflicts and review findings - #50
Merged
Merged
Conversation
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
⛔ Files ignored due to path filters (12)
📒 Files selected for processing (63)
✨ Finishing Touches
Comment |
purpshell
marked this pull request as ready for review
October 10, 2026 08:55
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #45 cannot accept project-maintainer fixes because its head is
tulir/whatsmeow:mainwith maintainer edits disabled. This project-owned replacement merges its exact upstream headc386243a72bacad080ba2938b37e1e4e0f1ca3b2into HyperMeowmainat9f40228a8de4dad6bdfe9a30f962cd925b91546cand resolves the conflicts while preserving HyperMeow's module path, semantic-version retractions, Polymorfa Signal fork, bounded queue overflow recovery, shadow-client boundaries, SQL batching, and shipped migrations.The new upstream bot root-secret migration is appended as version 19, avoiding a collision with HyperMeow's published version 16. Protobuf output is regenerated for the changed schemas using protoc 34.1 and protoc-gen-go 1.36.11 with HyperMeow package paths. Barback's local module dependencies follow the merged contract.
Existing review findings
All 11 existing actionable findings on #45 were verified against the exact upstream head and addressed:
contents: readand disable checkout credential persistence; wait for the active node handler before signaling queue completion; coalesce QR rotations and apply the newest secret before output; populateSendFBMessage's destination; include full bot edits in target-ID decryption.Valuewrapper; propagate primitive and view-model decoding failures; marshal unknown primitive/view-model/text metadata as raw JSON; retain every registered primitive's type discriminator.No additional automated review was requested. Original findings remain on #45 because these commits are on the replacement branch.
Validation
Final head:
39ba534709bede1080f99889ced78729544c5ac1. Pull-request CI passed both Go 1.26 and Go 1.27 matrix jobs, including build, tests, generated MEX validation, and pre-commit.go build ./...andgo test -race ./...passed.go test ./...passed.pre-commit run --all-filespassed with Go 1.27.1 and 1.27.2 tools, including vet, staticcheck, tidy, YAML, import formatting, and zerolog checks.452d5bb86b45(x/tools v0.51.0). Stable staticcheck v0.8.1 cannot read Go 1.27.2 export data; the pinned snapshot passes pre-commit on Go 1.27.2 and staticcheck on Go 1.26.9.benchmark_legacy, and race suites passed.git diff --checkpassed. No live WhatsApp account, PostgreSQL deployment, or downstream production runtime was exercised. Barback tests are local tests, not a full deployed benchmark.API, SDK, CLI, docs, release, and admin assessment
ChatSettingsStoremethods. Polymorfa's HTTP handlers/specs are unaffected becauseapps/api/go.modremains pinned to90f9e4ec2c88; this PR does not upgrade that consumer.README.mdandCHANGELOG.mdcover the upstream revision, Go requirements, send destination, QR refresh, rich-response behavior, and custom-store migration. Public Polymorfa Mintlify docs are unaffected because its pinned runner and customer API behavior do not change.maincommits and Go pseudo-versions. No merge, tag, or deployment is included.