Repository navigation
feat: the Pine app's interface pieces have stories, checked by Chromatic on every pull request - #16
Merged
Merged
Conversation
…tic on every pull request Storybook in desktop/ with stories for the primitives of src/ui.tsx, in light and dark, and a workflow that sends them to Chromatic on pull requests and pushes to next. Without the CHROMATIC_PROJECT_TOKEN secret the job says so and passes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…rs were missing from the lock file @napi-rs/wasm-runtime (pulled in by Storybook's tooling) has @emnapi/core and @emnapi/runtime as peers; npm on macOS left them out of the lock file and npm ci on Linux refused it. They are now named as devDependencies. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…s and docs pages desktop/src/ui/<Component>.stories.tsx for each primitive of ui.tsx, with `component` set and no `title`, so Storybook names them by path and derives controls and an autodocs page. Stories are named by state (On, Off, Disabled...). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: #3 starts changing the desktop renderer's primitives (
desktop/src/ui.tsx). Visual diffs per component make each such PR reviewable.What changes
@storybook/react-vite, devDependencies ofdesktop/only; nothing goes into the npm package).npm run storybook/npm run build-storybookindesktop/.desktop/src/ui.stories.tsx: Icons, LogoMark, Working, Buttons, Switches, SegmentedControl, Fields, EmptyState, ConfirmButton, Dialogs (open).prefers-color-scheme, so the preview rewrites those media rules to force a theme..github/workflows/chromatic.yml: on pull requests and pushes tonext,chromaui/actionwithonlyChangedandexitZeroOnChanges. Without theCHROMATIC_PROJECT_TOKENsecret it logs that it skipped and passes.docs/references/desktop.md, a Commands row inAGENTS.md.Checked:
npm run build-storybook,npm run checkindesktop/and at the root.Not checked: stories not yet viewed in a browser (theme toggle untested); the secret is not set yet.
🤖 Generated with Claude Code