Refresh site from static-tool-page-template#65
Conversation
Regenerates the site using the static-tool-page-template scaffold: extracts page content into site.config.mjs, swaps the legacy component CSS for a unified theme/landing stylesheet, converts guide pages to MDX, and replaces deploy-site.yml with split site-check (PR validation: prettier, cspell, astro check, build, Playwright a11y suite across mobile/tablet/desktop) and site-publish (main-only Pages deploy) workflows. Adds Playwright/axe-core tests, cspell config, prettier config, and a justfile front-end for the common npm scripts. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b291648663
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - name: Build | ||
| run: npm run build |
There was a problem hiding this comment.
On a push to main, this workflow deploys after only npm run build, while the new site-check.yml validation workflow runs independently and is not a prerequisite. That means changes that build but fail npm run check, spellcheck, formatting, or the Playwright link/accessibility tests can still be uploaded to GitHub Pages before/while the check workflow fails. Please either run the validation steps here before upload or make publishing depend on the completed check workflow.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Good catch — fixed in 1fcc959 by inlining the validation steps (format:check, spellcheck, astro check, Playwright + axe-core tests) before upload-pages-artifact, so a failed check now blocks the deploy. Also mirrored the fix to the template repo (plx/static-tool-page-template#4) with a regression test, so future generated sites inherit the gating.
🤖 Posted by Claude Code
The site deployment workflow was split into site-check.yml (PR validation) and site-publish.yml (build/deploy) but the navigation guide still referenced the old deploy-site.yml name, causing the Navigation Guide CI check to fail and block dependent jobs. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Run format:check, spellcheck, astro check, and Playwright tests before uploading the GitHub Pages artifact so a failed validation cannot ship. Previously the publish workflow only ran `npm run build`, while site-check.yml's validation ran independently and was not a prerequisite. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 participant
Description
Regenerates the Astro/Starlight site from the
static-tool-page-templatescaffold: extracts landing/docs content intosrc/site.config.mjs, replaces the legacy component CSS bundle with a unifiedtheme.css+ reworkedlanding.css, swaps Markdown guides for MDX, and renames the logo asset. Splits the previousdeploy-site.ymlintosite-check.yml(PR validation: prettier, cspell, astro check, build, and Playwright + axe-core a11y tests across mobile/tablet/desktop) andsite-publish.yml(main-only GitHub Pages deploy). Adds Playwright/axe-core tests, cspell config, prettier config, and ajustfilewrapping the common npm scripts.Type of Change
Testing
cargo test,cargo fmt --check,cargo clippy)npm run test/just test(requiresjust install-browsersonce)npm run build🤖 Generated with Claude Code