chore: trim passionfactory plugins and add AGENTS.md symlink#205
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes several '@passionfactory' plugins and its marketplace configuration from '.claude/settings.json', and adds a new 'AGENTS.md' file referencing 'CLAUDE.md'. There are no review comments, so I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Up to standards ✅🟢 Issues
|
![codacy-production[bot]](https://avatars.githubusercontent.com/in/56611?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull Request Overview
This PR successfully performs a cleanup of the .claude/settings.json file by removing the passionfactory marketplace and its associated plugins.
However, there are two primary issues that should be addressed before merging:
- Missing Deliverable: The
AGENTS.mdsymlink mentioned in the title and acceptance criteria is missing from the code changes. - Metadata Error: The manual PR description describes an unrelated 'Linear emulator' port, which does not match the content of this PR.
About this PR
- The
AGENTS.mdsymlink mentioned in the PR title was not found in the changes. Please ensure the symlink is created and included in the commit. - The PR description appears to be a copy-paste error as it references an unrelated 'Linear emulator' port. Please update the description to reflect the actual changes.
Test suggestions
- Verify that all @passionfactory plugins are removed from the settings file
- Verify that the 'passionfactory' marketplace entry is entirely removed
- Verify the creation and target of the AGENTS.md symlink
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify the creation and target of the AGENTS.md symlink
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
There was a problem hiding this comment.
Pull Request Overview
There is a critical misalignment between the pull request description and the provided code changes. While the PR summary and acceptance criteria detail a significant feature implementation—the @pleaseai/emulate-linear package port, including GraphQL support and CLI registration—none of these changes are present in the current diff. The actual changes are limited to trimming plugins from configuration and adding a text file.
Additionally, the implementation of AGENTS.md as a plain text file containing a path string does not function as a filesystem-level symbolic link, which contradicts the stated intent in the title and description. Although the automated quality checks are 'up to standards', the PR should not be merged until the missing implementation is included or the description is corrected.
About this PR
- Severe scope misalignment: The PR description details a comprehensive port of a Linear emulator service, including a new package, GraphQL resolvers, and tests. However, the diff only contains minor chore changes (cleaning up settings and adding a text file). Please ensure all intended files are staged and committed.
1 comment outside of the diff
AGENTS.md
line 1🟡 MEDIUM RISK
Suggestion: This file is a regular text file containing 'CLAUDE.md' rather than a filesystem-level symbolic link. If a true symlink was intended, please verify the implementation.
Test suggestions
- Verify passionfactory integrations are removed from configuration
- Verify AGENTS.md content/reference to CLAUDE.md
- Verify implementation of @pleaseai/emulate-linear package
- Verify CLI registration and registration in 'emulate list'
- Verify GraphQL resolvers for Linear entities (Issue, Project, User, etc.)
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify implementation of @pleaseai/emulate-linear package
2. Verify CLI registration and registration in 'emulate list'
3. Verify GraphQL resolvers for Linear entities (Issue, Project, User, etc.)
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found across 4 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Architecture diagram
sequenceDiagram
participant CLI as CLI (bun packages/emulate)
participant Registry as Service Registry
participant LinearPkg as @pleaseai/emulate-linear
participant Core as @emulators/core
participant GraphQL as GraphQL Endpoint
participant ExternalAPI as Linear API (read-only)
Note over CLI,ExternalAPI: System Architecture: Emulate Linear Service
CLI->>Registry: registerService("linear")
Registry-->>CLI: service registered
CLI->>LinearPkg: load linear service
LinearPkg->>Core: import Hono type from @emulators/core
Core-->>LinearPkg: Hono type available
Note over LinearPkg,ExternalAPI: Runtime Flow for GraphQL Queries
Client->>GraphQL: POST /graphql (Authorization: api_key)
GraphQL->>LinearPkg: handle incoming request
alt Missing or invalid auth
LinearPkg->>GraphQL: return 401 Unauthorized
GraphQL-->>Client: 401 response
else Valid auth
LinearPkg->>LinearPkg: parse query/mutation
alt POST method (only allowed)
LinearPkg->>ExternalAPI: fetch Linear API with API key
ExternalAPI-->>LinearPkg: Relay-style paginated results
LinearPkg-->>GraphQL: format response
GraphQL-->>Client: 200 + GraphQL data
else Other HTTP methods
LinearPkg->>GraphQL: return 405 Method Not Allowed
GraphQL-->>Client: 405 response
end
end
|
1 participant
Summary
Ports vercel-labs/emulate#91 (Phase 1 Linear emulator, by @mvanhorn) into this fork's conventions.
The upstream PR targets a different structure (pnpm,
@emulators/*scope, aapps/webdocs site,@emulators/coreas a workspace dep), so it could not be merged directly. The service core was re-homed to match this fork instead.What's included
@pleaseai/emulate-linearpackage underpackages/linear/@emulators/core@^0.6.0+graphqldeps,tsgotype-checklinearin the CLI service registry (packages/emulate) + dependency wiringHonotype sourced from@emulators/core(no directhonodep)405handlers for non-POST/graphql(core's router has noall)vitest→bun:testusingcreateServerif,node:bufferimport)skills/linear/SKILL.md, package README, and root README entries adapted to fork CLI usage (bun packages/emulate/dist/index.js --service linear)Excluded from the upstream PR
apps/web/*docs site,pnpm-lock.yaml, andemulate.config.example.yaml— these don't exist in this fork.Surface (read-only GraphQL)
POST /graphqlwith schema introspection, PAT auth (Authorization: <api_key>), Relay-style pagination, and query resolvers for Issue, Project, Team, User, Organization, Label, and WorkflowState.Verification
build(7) ·type-check(13) ·test(13, linear 26 pass) ·lintemulate listshows linear; service boots and answers GraphQL queries; missing auth returns401Follow-up work: mutations, webhooks, OAuth 2.0, inspector UI.
Summary by cubic
Removed the
passionfactorymarketplace and plugins from.claude/settings.jsonto trim unused integrations. Added Orca worktree provisioning viaorca.yamland.worktreeinclude, and createdAGENTS.mdas a symlink toCLAUDE.md.Written for commit 86b3df7. Summary will update on new commits.