Fix TS5107 by switching moduleResolution to "bundler"#244
Merged
Conversation
TypeScript 6.0 promotes the deprecated `moduleResolution: "node"` (node10) from a warning to a hard error (TS5107), which breaks `npm run docs` (typedoc) and `tsc`. Since `module` is already `ESNext` and the package is built with rollup, "bundler" is the correct modern replacement. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
TypeScript 6.0 (pinned as
typescript: 6.0.3) promotes the deprecatedmoduleResolution: "node"(node10) from a warning to a hard error (TS5107). This breaksnpm run docs(typedoc) andtsc:This is currently failing the api-reference GitHub Actions build, which clones
mainand runsnpm run docs.Fix
Switch
moduleResolutionfrom"node"to"bundler". Sincemoduleis alreadyESNextand the package is built with rollup,"bundler"is the correct modern replacement — cleaner than silencing withignoreDeprecations, which would only defer the problem until TS 7.0 removes the option entirely.Verification
Both pass cleanly with the change:
npm run docs— typedoc generates HTML with no errorsnpm run type-check(tsc --noEmit) — no errors🤖 Generated with Claude Code