fix: persist scene checkbox selection in publish/download picker#2089
Merged
Conversation
apply the builds panel design language to the version control pickers: kebab row menus with rounded bordered dropdowns, modern list row hover and header bars, toolbar-style branch actions, primary/secondary side panel buttons, modern form fields, and red destructive menu items.
display declarations on the changes tab, compare bar and view banner were defeating pcui-hidden and the hidden attribute, rendering every panel at once; gate them and drop the compare bar shadow.
the project picker closes on any pointerdown outside its content dom, so the branch dropdown and dialogs on layout root dismissed the whole picker when clicked; anchor them inside the picker panel instead and drop the branch dropdown shadow.
pcui renders [placeholder] as a fixed top-right chip with its own background, which floats outside the filter input, textarea and dialog fields; mirror the placeholder onto the native input elements instead and unify the muted color. drop the doubled divider at the bottom of the branch list.
8px gap on both axes, header-bar filter row with aligned 12px padding, builds-style group headers and badge radius, 6px corners on the dropdown, dialogs and compare bar.
the darkest slab background read as inconsistent against the top bar; blend at rest, darken on hover/open. the tooltip overlapped the open dropdown and duplicated the button label, so remove it.
the editor styles webkit scrollbars with an 8px black track, so any 1px horizontal overflow rendered as a thick dark band; clamp x overflow on the branch, history, changes and main scroll areas.
the context menu is wider than the 320px panel, so right-edge alignment clamped it onto the dropdown and buried it, reading as the dropdown vanishing.
restore the original menu position; the kebab keeps a pressed state and the row keeps its hover presentation until the menu hides, instead of the actions vanishing when the menu backdrop steals hover.
…ed values
- buildNameIndex: tolerate both flat {guid: name} and nested {entities: {guid: name}} scene payload shapes
- valueKind: explicit 'json' type now returns early before curve sniffing
- valueKind: curve sniffing only runs when type is empty, 'curve', or 'curveset'
- valueKind: remove unnecessary optional chain on string param
- export DiffCheckpoints and CheckpointLike types; replace diff: any with DiffCheckpoints
- add tests pinning nested entity shape, src-wins-over-dst for entities, json-typed curves, off-size arrays
…, destroy pass, selectable text)
The publish and zip download dialog rebuilt its scene list on every open and reset the selection to just the primary scene, forcing users with many scenes to re-tick their build set each time. Persist the selected scene ids in localStorage (keyed by project and branch, like the existing primary scene key), save on checkbox change and restore on open, falling back to the primary scene when nothing is stored.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
The publish / zip download dialog rebuilds its scene list on every open and resets the checkboxes to just the primary scene, so the selected scene set was lost each time. In projects with 30-40 scenes this means re-ticking 10-15 scenes for every build.
localStorageunderpublish:selectedScenes:<project>:<branch>, mirroring the existingpublish:primaryScenekeychangeevent)Checks