feat: disable flamegraphs by default - #250
Merged
Merged
Conversation
Signed-off-by: marcopiraccini <marco.piraccini@gmail.com>
marcopiraccini
marked this pull request as ready for review
August 28, 2026 07:39
ivan-tymoshenko
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flips the default of
PLT_DISABLE_FLAMEGRAPHSfromfalsetotrue: pods now boot with continuous profiling off unless a deployment explicitly opts in.Why this makes sense now
Until #229, this default was the only control profiling had: it was set at boot, for the whole pod, forever. Disabling by default would have meant nobody gets flamegraphs at all, so profiling-on was the only usable default.
That constraint is gone. Since #229 (and the ICC per-pod toggle UI):
In short: profiling-by-default existed because there was no other way to get a profile. Now that there is, the default can follow the principle of least surprise: do nothing until asked.
Behavior changes to be aware of
PLT_DISABLE_FLAMEGRAPHS=false.