fix: report partial and unresponsive profiling states - #241
Merged
Conversation
Signed-off-by: marcopiraccini <marco.piraccini@gmail.com>
marcopiraccini
marked this pull request as ready for review
August 24, 2026 14:01
marcopiraccini
requested review from
ShogunPanda,
ivan-tymoshenko and
leorossi
August 24, 2026 14:01
ShogunPanda
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Profiling state reporting previously treated pod-side intent as actual state and could stall indefinitely when a worker event loop was blocked. This could make partial activation appear successful or cause the pod state to expire from ICC.
This change:
isCapturingstate for every worker and profile typeunresponsive, allowing ICC to showPending,Partial, orUnknowninstead of treating the healthy subset as the whole podConfiguration
Adds
PLT_FLAMEGRAPHS_STATE_QUERY_TIMEOUT, in milliseconds, with a default of5000.