Skip to content

fix: report partial and unresponsive profiling states - #241

Merged
marcopiraccini merged 1 commit into
mainfrom
fix/profiling-state-reporting
Aug 24, 2026
Merged

fix: report partial and unresponsive profiling states#241
marcopiraccini merged 1 commit into
mainfrom
fix/profiling-state-reporting

Conversation

@marcopiraccini

@marcopiraccini marcopiraccini commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Summary

Profiling state reporting previously treated pod-side intent as actual state and could stall indefinitely when a worker event loop was blocked. This could make partial activation appear successful or cause the pod state to expire from ICC.

This change:

  • reports the real isCapturing state for every worker and profile type
  • returns a failed toggle result when one or more workers fail to start or stop profiling
  • queries worker states in parallel with a configurable timeout
  • coalesces concurrent reports so slow workers or scaler requests do not create overlapping runs
  • applies bounded backoff to workers whose state queries time out
  • keeps timed-out workers in reports as unresponsive, allowing ICC to show Pending, Partial, or Unknown instead of treating the healthy subset as the whole pod
  • clears worker suppression when the worker restarts

Configuration

Adds PLT_FLAMEGRAPHS_STATE_QUERY_TIMEOUT, in milliseconds, with a default of 5000.

Signed-off-by: marcopiraccini <marco.piraccini@gmail.com>
@marcopiraccini
marcopiraccini marked this pull request as ready for review August 24, 2026 14:01
@marcopiraccini
marcopiraccini merged commit 055fb50 into main Aug 24, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants