Fix Expo 56 LinkKit pod install#932
Merged
Merged
Conversation
|
Coverage after merging codex/fix-issue-931-linkkit-xcframework into master will be
Coverage Report
|
|||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LinkKit.xcframeworklosing Mac Catalyst framework symlinks.ios-arm64andios-arm64_x86_64-simulator.Motivation
Fixes #931.
The published package included a Mac Catalyst slice whose framework symlinks were omitted by
npm pack. CocoaPods validates all XCFramework slices, even when Catalyst is disabled, so it treated the broken Catalyst slice as static and failed with:Testing
npm run check:linkkitnpm run check:packagenpm run lintnpm pack --jsonnpx prettier --check .github/workflows/pull_request.yml README.md package.json scripts/check-package-entrypoints.js scripts/validate-linkkit-xcframework.js scripts/strip-linkkit-maccatalyst.js.github/workflows/pull_request.ymlwith Ruby YAML.Result: