Skip to content

Fix: Hide version selector on Home page and make v1 default#6480

Open
rahulshendre wants to merge 1 commit intopipe-cd:masterfrom
rahulshendre:fix/version-inconsistency-homepage
Open

Fix: Hide version selector on Home page and make v1 default#6480
rahulshendre wants to merge 1 commit intopipe-cd:masterfrom
rahulshendre:fix/version-inconsistency-homepage

Conversation

@rahulshendre
Copy link
Contributor

What this PR does:

  • Hide version selector on the homepage.
  • Set docs default to latest, docs-v1.0

Why we need it:
Homepage was showing a different version than the docs due to hardcoded selector and as v1 is going to be the latest version, we need it to be the default.

Which issue(s) this PR fixes:

Fixes #6478

@rahulshendre
Copy link
Contributor Author

@eeshaanSA, PTAL when you have time : )

Copy link
Contributor

@eeshaanSA eeshaanSA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@rahulshendre
Copy link
Contributor Author

@eeshaanSA, there is one more thing I noticed. On smaller screens (phones), the version selector is not visible, so users currently have no way to change the version.

Earlier users landed on v0.55, but after this PR they will land on v1 docs by default. However, on mobile they still won’t be able to switch versions since the selector is hidden.

After we get this PR is merged, I’ll open a separate issue for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Version selector has inconsistent version on homepage

2 participants