Open
Conversation
antedotee
force-pushed
the
doc-right-section-fix
branch
2 times, most recently
from
ad9c07d to
6e5a7d4
Compare
Author
|
@eeshaanSA Please take a look. |
docs/assets/js/toc-scroll-spy.js
Outdated
Comment on lines
70
to
71
| activeSection.link.style.fontWeight = 'bold'; | ||
| activeSection.link.style.color = '#007bff'; // Bootstrap primary color |
Contributor
There was a problem hiding this comment.
@antedotee, wouldn't it be better to let JS only toggle the active class and keep all styling in SCSS to avoid duplication and overrides, what do you think?
Contributor
animation_right_side.mp4@eeshaanSA As mentioned in the previous meeting, you suggested that anyone with JS experience to take a look at this. I have reviewed and tested it locally. Overall the behavior looks good. A couple of suggestions:
Please address the review comment about removing inline styles from JS. Once those are fixed, this LGTM. |
antedotee
force-pushed
the
doc-right-section-fix
branch
from
6e5a7d4 to
00bfef9
Compare
Signed-off-by: antedotee <[email protected]>
Signed-off-by: antedotee <[email protected]>
… shift by reserving space for inactive links Signed-off-by: antedotee <[email protected]>
antedotee
force-pushed
the
doc-right-section-fix
branch
from
00bfef9 to
8aff33e
Compare
Author
|
@rahulshendre I have implemented the suggested changes. Please have a look and let me know if there are any further improvements to be worked upon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR adds the functionality of highlighting of the right section along with scrolling of the main content.
Why we need it:
To enhance the user experience
Fixes #6464