-
Notifications
You must be signed in to change notification settings - Fork 331
cluster: support tikv-worker #2677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2677 +/- ##
==========================================
- Coverage 42.30% 42.15% -0.15%
==========================================
Files 424 426 +2
Lines 46888 47044 +156
==========================================
- Hits 19834 19830 -4
- Misses 24390 24546 +156
- Partials 2664 2668 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/cc @xhebox @breezewish |
The comment is true. Isn't this break that behavior? |
http://tiup.pingcap.net:8988/ tikv-worker is an independent package. |
Signed-off-by: Lloyd-Pottiger <[email protected]>
ff3f264 to
bfb04e6
Compare
It is. But in some old packages, it is not. |
What problem does this PR solve?
close #xxx
What is changed and how it works?
Support tikv-worker in TiUP Cluster.
Check List
Tests
Code changes
Side effects
Related changes
Release notes: