playground: add dm support for playground#2465
Conversation
Signed-off-by: Siddon Tang <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
|
ti-chi-bot
bot
added
the
size/XL
|
@Benjamin2037: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| p.bootOptions = options | ||
|
|
||
| // All others components depend on the pd, we just ensure the pd count must be great than 0 | ||
| if options.PDMode != "ms" && options.PD.Num < 1 { |
There was a problem hiding this comment.
Good question，if we set dm as a default part for palyground maybe not a good idea，when user issue tiup playground，maybe this should not include start a dm cluster。 What do you think？@GMHDBJD @xhebox
Yes, I don't think it should be included here. And it did not break playground only because PD.Num >= 1 in normal cases...
There was a problem hiding this comment.
dmmaster.num defaults 0, pd.num defaults 1, so tiup playground start a tidb cluster default, but I think we should allow user start a dm cluster without tidb/pd/tikv, so here change the logic to allow follow command.
tiup-playground nightly --dm-master 1 --dm-worker 1 --db 0 --kv 0 --pd 0 --tiflash 0
| colorCmd.Printf("tiup dmctl --master-addr %s\n", strings.Join(endpoints, ",")) | ||
| } | ||
|
|
||
| if len(p.pds) > 0 { |
There was a problem hiding this comment.
Now we can start a dm cluster without pd, so allow pd to be zero
tiup-playground nightly --dm-master 1 --dm-worker 1 --db 0 --kv 0 --pd 0 --tiflash 0
[LGTM Timeline notifier]Timeline:
|
5 participants
What problem does this PR solve?
support DM in playground. ref #2464
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Release notes: