Skip to content

OWNERS: sync master to release-8.5#69501

Open
ti-chi-bot wants to merge 1 commit into
release-8.5from
bot/sync-owners-to-release-8.5
Open

OWNERS: sync master to release-8.5#69501
ti-chi-bot wants to merge 1 commit into
release-8.5from
bot/sync-owners-to-release-8.5

Conversation

@ti-chi-bot

@ti-chi-bot ti-chi-bot commented Jun 27, 2026

Copy link
Copy Markdown
Member

What problem does this PR solve?

Sync OWNERS* files from master to release-8.5.

What changed and how does it work?

This PR was auto-generated by Prow and only updates OWNERS and OWNERS_ALIASES files.

/release-note-none
skip-issue-check
lgtm
approved
cherry-pick-approved

Summary by CodeRabbit

  • New Features

    • Expanded ownership rules across multiple areas, adding path-based approval and review coverage for more targeted change control.
    • Introduced several new approval/review groups for specialized components and teams.
  • Bug Fixes

    • Updated approval assignments for some paths so changes are routed to the appropriate reviewer groups.
    • Refined ownership for session, statistics, and executor-related areas to better match their current responsibilities.
  • Chores

    • Removed large static user lists in favor of simpler rule-based ownership configuration.

skip-checks: true
Signed-off-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added approved cherry-pick-approved Cherry pick PR approved by release team. lgtm skip-issue-check Indicates that a PR no need to check linked issue. labels Jun 27, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jun 27, 2026

Copy link
Copy Markdown

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot Bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 27, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jun 27, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign d3hunter, terry1purcell for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added sig/planner SIG: Planner and removed approved labels Jun 27, 2026
@coderabbitai

coderabbitai Bot commented Jun 27, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The PR replaces the root OWNERS username lists with path-based filters, updates alias group membership in OWNERS_ALIASES, and adds or revises OWNERS rules for executor, statistics, dumpformat, dxf, ingestor, lightning, meta, session, sessionctx, util/naming, and metrics paths.

Changes

Ownership rules and alias mappings

Layer / File(s) Summary
Alias memberships
OWNERS_ALIASES
sig-approvers-stats, sig-critical-approvers-dep, and sig-approvers-dxf are added, several existing alias member lists are updated, and sig-community-reviewers / sig-community-approvers are rewritten.
Root OWNERS filters
OWNERS
The root OWNERS file switches from explicit username lists to path-based filters, including a go.mod rule and a default rule for other paths.
Executor, stats, and metrics OWNERS
pkg/executor/OWNERS, pkg/executor/.../OWNERS, pkg/executor/test/analyzetest/OWNERS, pkg/statistics/OWNERS, pkg/metrics/OWNERS
Executor subpaths, analyzer tests, statistics, and metrics directories are assigned SIG approver groups, and pkg/statistics/OWNERS also changes its label list.
Dumpformat and dxf OWNERS
pkg/dumpformat/OWNERS, pkg/dxf/OWNERS
pkg/dumpformat/OWNERS switches its approver group, and pkg/dxf/OWNERS adds a new no-parent rule with sig-approvers-dxf.
DDL, session, and meta OWNERS
pkg/ingestor/OWNERS, pkg/lightning/config/OWNERS, pkg/meta/metadef/OWNERS, pkg/session/OWNERS, pkg/sessionctx/vardef/OWNERS, pkg/util/naming/OWNERS
These package paths add or update no-parent OWNERS rules and path-based approver filters for DDL, Lightning, meta, session, and vardef files.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Possibly related PRs

  • pingcap/tidb#67717: Also updates OWNERS governance and sig-community-* alias membership.
  • pingcap/tidb#68706: Also rewrites OWNERS and OWNERS_ALIASES to use SIG-based ownership groups.
  • pingcap/tidb#68891: Touches pkg/dumpformat/OWNERS and pkg/dxf/OWNERS, matching two package-level ownership changes here.

Suggested labels

approved

Suggested reviewers

  • windtalker
  • wshwsh12
  • GMHDBJD

Poem

I hopped through the OWNERS moonlit page,
Swapping paths and groups with a twitchy nose.
Community bunnies lined up in rows,
Now every trail knows where approval goes.
Thump thump — the config sings softly tonight.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description covers the sync and change summary but omits required template items like Issue Number and the checklist. Add the required Issue Number line, checklist entries, and a release note block matching the repository template.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly states this is an OWNERS sync from master to release-8.5.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bot/sync-owners-to-release-8.5

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@OWNERS`:
- Around line 4-9: The OWNERS pattern for the catch-all currently also matches
go.mod, which lets dependency changes fall through to the broader approver
group. Update the matching rules so go.mod is excluded from the generic
catch-all and remains owned only by the go.mod-specific entry, using the OWNERS
patterns and approver blocks already defined there.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 3ab228a9-c48b-4b0d-93be-71544c1d3985

📥 Commits

Reviewing files that changed from the base of the PR and between df2282c and d155694.

📒 Files selected for processing (21)
  • OWNERS
  • OWNERS_ALIASES
  • pkg/dumpformat/OWNERS
  • pkg/dxf/OWNERS
  • pkg/executor/OWNERS
  • pkg/executor/aggfuncs/OWNERS
  • pkg/executor/aggregate/OWNERS
  • pkg/executor/join/OWNERS
  • pkg/executor/mppcoordmanager/OWNERS
  • pkg/executor/sortexec/OWNERS
  • pkg/executor/test/analyzetest/OWNERS
  • pkg/executor/unionexec/OWNERS
  • pkg/ingestor/OWNERS
  • pkg/lightning/config/OWNERS
  • pkg/meta/metadef/OWNERS
  • pkg/metrics/OWNERS
  • pkg/objstore/OWNERS
  • pkg/session/OWNERS
  • pkg/sessionctx/vardef/OWNERS
  • pkg/statistics/OWNERS
  • pkg/util/naming/OWNERS

Comment thread OWNERS
Comment on lines +4 to +9
go\.mod$:
approvers:
- sig-critical-approvers-dep
.*:
approvers:
- sig-community-approvers

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔒 Security & Privacy | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Show which root OWNERS filter patterns match go.mod.
python - <<'PY'
import pathlib, re

patterns = []
for line in pathlib.Path("OWNERS").read_text().splitlines():
    if line.startswith("  ") and line.rstrip().endswith(":") and not line.startswith("    "):
        patterns.append(line.strip()[:-1])

matches = [p for p in patterns if p == ".*" or re.search(p, "go.mod")]
print("patterns matching go.mod:", matches)
PY

Repository: pingcap/tidb

Length of output: 196


Prevent go.mod from matching the catch-all approvers. .* also matches go.mod, so dependency changes are approvable by sig-community-approvers as well as sig-critical-approvers-dep. Split the catch-all into non-go.mod patterns if that broader approval path is not intended.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@OWNERS` around lines 4 - 9, The OWNERS pattern for the catch-all currently
also matches go.mod, which lets dependency changes fall through to the broader
approver group. Update the matching rules so go.mod is excluded from the generic
catch-all and remains owned only by the go.mod-specific entry, using the OWNERS
patterns and approver blocks already defined there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick-approved Cherry pick PR approved by release team. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. lgtm sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant