OWNERS: sync master to release-8.5#69501
Conversation
skip-checks: true Signed-off-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
📝 WalkthroughWalkthroughThe PR replaces the root OWNERS username lists with path-based filters, updates alias group membership in OWNERS_ALIASES, and adds or revises OWNERS rules for executor, statistics, dumpformat, dxf, ingestor, lightning, meta, session, sessionctx, util/naming, and metrics paths. ChangesOwnership rules and alias mappings
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@OWNERS`:
- Around line 4-9: The OWNERS pattern for the catch-all currently also matches
go.mod, which lets dependency changes fall through to the broader approver
group. Update the matching rules so go.mod is excluded from the generic
catch-all and remains owned only by the go.mod-specific entry, using the OWNERS
patterns and approver blocks already defined there.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 3ab228a9-c48b-4b0d-93be-71544c1d3985
📒 Files selected for processing (21)
OWNERSOWNERS_ALIASESpkg/dumpformat/OWNERSpkg/dxf/OWNERSpkg/executor/OWNERSpkg/executor/aggfuncs/OWNERSpkg/executor/aggregate/OWNERSpkg/executor/join/OWNERSpkg/executor/mppcoordmanager/OWNERSpkg/executor/sortexec/OWNERSpkg/executor/test/analyzetest/OWNERSpkg/executor/unionexec/OWNERSpkg/ingestor/OWNERSpkg/lightning/config/OWNERSpkg/meta/metadef/OWNERSpkg/metrics/OWNERSpkg/objstore/OWNERSpkg/session/OWNERSpkg/sessionctx/vardef/OWNERSpkg/statistics/OWNERSpkg/util/naming/OWNERS
| go\.mod$: | ||
| approvers: | ||
| - sig-critical-approvers-dep | ||
| .*: | ||
| approvers: | ||
| - sig-community-approvers |
There was a problem hiding this comment.
🔒 Security & Privacy | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Show which root OWNERS filter patterns match go.mod.
python - <<'PY'
import pathlib, re
patterns = []
for line in pathlib.Path("OWNERS").read_text().splitlines():
if line.startswith(" ") and line.rstrip().endswith(":") and not line.startswith(" "):
patterns.append(line.strip()[:-1])
matches = [p for p in patterns if p == ".*" or re.search(p, "go.mod")]
print("patterns matching go.mod:", matches)
PYRepository: pingcap/tidb
Length of output: 196
Prevent go.mod from matching the catch-all approvers. .* also matches go.mod, so dependency changes are approvable by sig-community-approvers as well as sig-critical-approvers-dep. Split the catch-all into non-go.mod patterns if that broader approval path is not intended.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@OWNERS` around lines 4 - 9, The OWNERS pattern for the catch-all currently
also matches go.mod, which lets dependency changes fall through to the broader
approver group. Update the matching rules so go.mod is excluded from the generic
catch-all and remains owned only by the go.mod-specific entry, using the OWNERS
patterns and approver blocks already defined there.
What problem does this PR solve?
Sync
OWNERS*files frommastertorelease-8.5.What changed and how does it work?
This PR was auto-generated by Prow and only updates
OWNERSandOWNERS_ALIASESfiles./release-note-none
skip-issue-check
lgtm
approved
cherry-pick-approved
Summary by CodeRabbit
New Features
Bug Fixes
Chores