Update perror code and regenerate perror.go#127
Open
dveeden wants to merge 2 commits into
Open
Conversation
mjonss
previously approved these changes
Jul 4, 2024
mjonss
left a comment
mjonss
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, with minor suggestion
dveeden
marked this pull request as draft
July 29, 2024 06:31
dveeden
marked this pull request as ready for review
July 29, 2024 06:31
Collaborator
Author
|
Not sure what's needed to get "license/cla" to report ✔️ |
Collaborator
Author
https://cla.pingcap.net/pingcap/mysql-tester?pullRequest=127 says: Error There is no CLA to sign for pingcap/mysql-tester (could not find linked item for owner pingcap and repo mysql-tester) |
Collaborator
Author
bb7133
reviewed
Jun 4, 2026
|
|
||
| const ( | ||
| fileHeader = `// Copyright 2023 PingCAP, Inc. | ||
| fileHeader = `// Copyright 2024 PingCAP, Inc. |
Collaborator
Author
There was a problem hiding this comment.
This was because this PR was created in 2024.
Also note that years in copyright shouldn't really matter much: https://daniel.haxx.se/blog/2023/01/08/copyright-without-years/
| @@ -1,4 +1,4 @@ | |||
| // Copyright 2023 PingCAP, Inc. | |||
| // Copyright 2024 PingCAP, Inc. | |||
Collaborator
Author
|
@bb7133 PTAL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
perror.go.For CI:
perror.goin CI.go.modinstead of a hardcoded one