Skip to content

schedulingpb: add split reason to ask batch split request#1475

Merged
ti-chi-bot[bot] merged 1 commit into
pingcap:release-nextgen-202603from
lhy1024:backport-scheduling-split-reason-nextgen-202603
Jul 3, 2026
Merged

schedulingpb: add split reason to ask batch split request#1475
ti-chi-bot[bot] merged 1 commit into
pingcap:release-nextgen-202603from
lhy1024:backport-scheduling-split-reason-nextgen-202603

Conversation

@lhy1024

@lhy1024 lhy1024 commented May 25, 2026

Copy link
Copy Markdown
Member

What problem does this PR solve?

Backport the schedulingpb part needed by tikv/pd#10708 to release-nextgen-202603.

The PD scheduling-service path needs AskBatchSplitRequest.reason so it can keep affinity split checks consistent with the local PD path.

What is changed and how does it work?

  • Add pdpb.SplitReason reason = 4 to schedulingpb.AskBatchSplitRequest.
  • Regenerate pkg/schedulingpb/schedulingpb.pb.go.
  • Update scripts/proto.lock.

This only cherry-picks the schedulingpb split-reason field from #1459.

Tests

GOFLAGS='-buildvcs=false' GO111MODULE=on go test ./pkg/schedulingpb

@ti-chi-bot ti-chi-bot Bot requested review from fzzf678 and js00070 May 25, 2026 06:23
@ti-chi-bot ti-chi-bot Bot added the size/L label May 25, 2026
Signed-off-by: lhy1024 <19542290+lhy1024@users.noreply.github.com>
@lhy1024 lhy1024 force-pushed the backport-scheduling-split-reason-nextgen-202603 branch from a2fb5fd to c8629cb Compare May 25, 2026 06:40
@ti-chi-bot

ti-chi-bot Bot commented Jun 3, 2026

Copy link
Copy Markdown

@bufferflies: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot

ti-chi-bot Bot commented Jul 3, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bufferflies, disksing, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Jul 3, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jul 3, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-06-03 07:29:32.524008878 +0000 UTC m=+340273.594326269: ☑️ agreed by disksing.
  • 2026-07-03 01:52:13.206048961 +0000 UTC m=+349874.906428394: ☑️ agreed by rleungx.

@ti-chi-bot ti-chi-bot Bot merged commit e800f9e into pingcap:release-nextgen-202603 Jul 3, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants