Conversation
Signed-off-by: disksing <i@disksing.com>
disksing
changed the title
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
# Conflicts: # pkg/kvrpcpb/kvrpcpb.pb.go # pkg/pdpb/pdpb.pb.go Signed-off-by: disksing <i@disksing.com>
| uint64 n = 4; | ||
| int64 increment = 5; | ||
| int64 offset = 6; | ||
| // V1/V2 compatibility keyspace id. V3 should use keyspace_identity. |
There was a problem hiding this comment.
| // V1/V2 compatibility keyspace id. V3 should use keyspace_identity. | |
| // V1/V2 compatibility keyspace id. V3 should use keyspace_identity. | |
| oneof keyspace { | |
| uint32 keyspaceID = 7; | |
| apipb.KeyspaceIdentity identity = 8; | |
| } |
| KeyspaceMeta keyspace = 2; | ||
| } | ||
|
|
||
| message LookupKeyspaceRequest { |
There was a problem hiding this comment.
Can we find out some scenarios when looking up keyspaces with a given name across multiple namespaces make senses.
| ResponseHeader header = 1; | ||
|
|
||
| uint64 safe_point = 2; | ||
| // V3 keyspace identity served by this response. |
There was a problem hiding this comment.
Is the keyspace identity helpful when it is already known when sending the request
|
|
||
| uint64 new_safe_point = 2; | ||
| // V3 keyspace identity served by this response. | ||
| apipb.KeyspaceIdentity keyspace_identity = 3; |
There was a problem hiding this comment.
Is the keyspace identity helpful when it is already known when sending the request
| int64 ttl = 3; | ||
| uint64 min_safe_point = 4; | ||
| // V3 keyspace identity served by this response. | ||
| apipb.KeyspaceIdentity keyspace_identity = 5; |
There was a problem hiding this comment.
Is the keyspace identity helpful when it is already known when sending the request
| // V1/V2 compatibility pagination cursor. V3 should use namespace_id and start_keyspace_identity. | ||
| uint32 start_id = 2; | ||
| uint32 limit = 3; | ||
| // V3 namespace-limited pagination. Must be non-zero in V3. |
There was a problem hiding this comment.
namespace-scoped pagnination
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
2 participants
Summary
Validation