Repository navigation
compatible_shim: clear all unused fields on UnmarshalJSON() - #91
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the change to clear stale state after successful JSON unmarshalling.
No open issues 🎉
What changed in this PR
Updates Error.UnmarshalJSON() to clear stale local state when decoding successfully into an existing error.
Changes:
- Clears arguments, cause, redaction positions, and source location after successful decoding.
- Adds regression tests for state clearing, literal message preservation through JSON round-trips, and unchanged receiver state on invalid input.
| File | Description |
|---|---|
compatible_shim.go |
Resets fields not populated by JSON after successful unmarshalling. |
compatible_shim_test.go |
Tests successful state clearing, message preservation, and invalid-input handling. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.