Fix: Allow --config to specify a custom configuration path#1378
Open
ErwannCodes wants to merge 2 commits intopimutils:masterfrom
Open
Fix: Allow --config to specify a custom configuration path#1378ErwannCodes wants to merge 2 commits intopimutils:masterfrom
ErwannCodes wants to merge 2 commits intopimutils:masterfrom
Conversation
WhyNotHugo
reviewed
Apr 15, 2025
| @@ -0,0 +1,11 @@ | |||
| Metadata-Version: 2.1 | |||
Member
There was a problem hiding this comment.
This file should not have been committed.
| @@ -0,0 +1,188 @@ | |||
| .coveragerc | |||
| setproctitle('khal') | ||
| if ctx.logfilepath: | ||
| # S'assurer que ctx.obj est initialisé | ||
| if ctx.obj is None: |
Member
There was a problem hiding this comment.
You don't need to check for this explicitly; ensure_object only sets the inner object if is None. I.e.: it already does the check for you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolving the Issue: Using --config for a Custom Configuration Path
Problem: When a user specified the --config option with khal configure, the configuration file was always created in ~/.config/khal/config, even if a valid custom path was provided.
Identified Causes:
The value of --config was not correctly passed to configwizard.
Permissions for the specified path were not checked, leading to silent errors or failures.
Solution Provided
Correctly Passing --config:
The configure command now properly passes the --config value to configwizard.
configwizard uses this value to create or validate the configuration file.
Permission Handling:
If the specified path does not exist, it is automatically created.
If the necessary permissions are not available, a clear error message is displayed.
Handling Existing Files:
If a configuration file already exists at the specified path, a critical message is displayed, and the process is aborted to prevent overwriting.