Adding support for .spz files#233
Open
Joel-Y-18 wants to merge 2 commits into
Open
Conversation
Owner
|
Thanks @Joel-Y-18 this looks great ! 🙏 Before merging we'll just have to wait for nianticlabs/spz#89 and a new release of spz because it looks like they pulled zlib 1.3.1 (which is a dep of spz) and it currently breaks the build on Windows. Another option could be to make .spz support optional via a cmake flag. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small PR to add support for .spz outputs. Closes #164. In the issue there was a suggestion to wait until it is clear that .spz will be supported in the future - this seems to be the case.
I am a new contributor, so feedback is welcome.
Outputs are identical (300 iterations on CPU):
