Skip to content

Adding support for .spz files#233

Open
Joel-Y-18 wants to merge 2 commits into
pierotofy:mainfrom
Joel-Y-18:add-spz-support
Open

Adding support for .spz files#233
Joel-Y-18 wants to merge 2 commits into
pierotofy:mainfrom
Joel-Y-18:add-spz-support

Conversation

@Joel-Y-18

Copy link
Copy Markdown

Small PR to add support for .spz outputs. Closes #164. In the issue there was a suggestion to wait until it is clear that .spz will be supported in the future - this seems to be the case.

I am a new contributor, so feedback is welcome.

Outputs are identical (300 iterations on CPU):
Screenshot from 2026-05-25 18-27-47

@pierotofy

pierotofy commented May 25, 2026

Copy link
Copy Markdown
Owner

Thanks @Joel-Y-18 this looks great ! 🙏

Before merging we'll just have to wait for nianticlabs/spz#89 and a new release of spz because it looks like they pulled zlib 1.3.1 (which is a dep of spz) and it currently breaks the build on Windows.

  -- Using src='https://zlib.net/zlib-1.3.1.tar.gz'
  CMake Error at zlib-subbuild/zlib-populate-prefix/src/zlib-populate-stamp/download-zlib-populate.cmake:163 (message):
    Each download failed!

Another option could be to make .spz support optional via a cmake flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add .spz file outputs

2 participants