Fix a compiler warning in libymsg#61
Merged
Merged
Conversation
EionRobb
approved these changes
Aug 4, 2025
Contributor
|
Would having an |
Member
Author
|
That might be an idea but we've been trying to not just completely rewrite history. But the compiler did catch this one so I dunno. |
QuLogic
reviewed
Aug 5, 2025
Comment on lines
+4926
to
+4928
| if (fed) { | ||
| yahoo_packet_hash_int(pkt, 241, fed); | ||
| } |
Contributor
There was a problem hiding this comment.
AFAICT, the whole file uses tabs, so might as well fix that while here.
Suggested change
| if (fed) { | |
| yahoo_packet_hash_int(pkt, 241, fed); | |
| } | |
| if (fed) { | |
| yahoo_packet_hash_int(pkt, 241, fed); | |
| } |
The warning was that the mixed indentation could make it look like the line two below the if might be covered by the if. So just putting braces on the body of the if was enough to make it happy without a ton of modification.
QuLogic
approved these changes
Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The warning was that the mixed indentation could make it look like the line two below the if might be covered by the if. So just putting braces on the body of the if was enough to make it happy without a ton of modification.