Repository navigation
Start the cold run of the warm-rewrite test in a new second - #6697
Merged
ondrejmirtes merged 1 commit intoOct 7, 2026
Merged
Conversation
A file modified in the second the analysis starts gets no stat signature. When the cold run started in the second setUp() wrote the files, the warm run recorded the signatures and rewrote the result cache, so testWarmAnalysisDoesNotRewriteUnchangedResultCache failed. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Member
|
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
testWarmAnalysisDoesNotRewriteUnchangedResultCachefails often in "Integration tests", for example on #6694 and #6690. The warm run reports "Result cache restored. 0 files will be reanalysed." and then rewrites the result cache.The cause is the clock second.
FileStatSignatureReadergives no signature to a file modified in the second the analysis starts.setUp()writes the files, and the cold run usually starts in the same second, so it saves the result cache without signatures. The warm run starts in a later second, records the signatures, and rewrites the cache because they differ from the saved ones (fileStatSignaturesDiffer()). That is the intended behaviour, so the fix is in the test: it waits for the next second before the cold run. This adds at most one second to the test.Verification, locally on 5f76acd:
ResultCacheInfoCommandTestpassed 3 times.make phpstanreports no errors, and phpcs passes on the test file.🤖 Generated with Claude Code