Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #6018 (comment).
PureMethodRuleruns onMethodReturnStatementsNode, which only methods with a body get, so PHPStan never checked the purity declarations of abstract and interface methods:PHPStan reports the same declarations on a method with a body as
pureMethod.parameterByRefandpureMethod.nonOptionalParameterPassed.Changes
FunctionPurityCheck::checkSignature()holds the checks that need only the signature:parameterByRefandvoidfor@phpstan-pure,redundantUnlessCallablefor@pure-unless-callable-is-impure, andnonOptionalParameterPassed/parameterPassedNotByReffor@pure-unless-parameter-passed.check()calls it first, soPureFunctionRule,PureMethodRuleandPurePropertyHookRulereport the same errors as before.PureAbstractMethodRulerunscheckSignature()onInClassMethodNodefor methods without a body, with the samepureMethod.*identifiers.@phpstan-pureinterface methods, so I registered it on level 2 (likePureMethodRule) behind thereportAbstractMethodPuritybleeding-edge toggle.