More dependency tracking: directories, classes, declarations, closure and type-specifying extensions

[ondrejmirtes]

More scenarios for tracking result cache dependencies, from a survey of where popular extensions make the result cache stale.

• Parameter closure type and closure this extensions get Scope&DependencyTracker (Pest's extend() types $this in test closures from tests/Pest.php).
• Type-specifying extensions get Scope&DependencyTracker (webmozart/assert's implementsInterface() with a class named in a string).
• DependencyTracker::trackDirectoryDependency($directory, $pattern = '*'): the analysis depends on which files there are in a directory, recursively, whose names match a pattern - Larastan's views, migrations, Doctrine mapping directories, Drupal module discovery, finding every Pest.php. Only which files exist, not their contents (that's trackFileDependency()).
• DependencyTracker::trackClassDependency($className): the analysis depends on a class as if the code referenced it - a class named in a string (DQL, config('Name'), @covers, @dataProvider Other::method, class_exists() on a built name). The value is the exported nodes of the class and its ancestors, so a changed signature or PHPDoc counts and an edited method body doesn't, and the class being created, deleted or moved is noticed.
• DeclarationDependencyTracker: for extensions that get no Scope because they describe a class - class reflection extensions adding magic methods and properties (Carbon macros, Larastan model properties, Faker providers, Magento extension attributes, Doctrine's findByX()). Inject it and track on the ClassReflection. What such an extension declares is reused by every file analysed after it without asking the extension again, so the values are kept per class for the whole process, and every file depending on the class - or a class extending or implementing it - gets them as its own dependencies.

One commit each, plus the turbo version bump for the two new MutatingScope methods.

e2e/result-cache-value-dependency has a step for each: a closure $this extension, a type-specifying extension, a rule looking for a template in a directory, a dynamic return type extension naming a class in a string (created outside the analysed paths, then its parent's method body and signature changed), and a magic method of a class reflection extension called from two files. Each step fails when its tracking call is removed.

🤖 Generated with Claude Code

https://claude.ai/code/session_01GdwtgiEHwkF5BTz73jgHQQ

[staabm]

oh wow. I did not imagine you would go this far with this new extension type. its really cool <3.

[ondrejmirtes]

I'm going even further 😂 #6662

[canvural]

Can we also get for property extensions? In Larastan I read the database migrations when a undefined property is accessed.

[ondrejmirtes]

@canvural Yeah it's in there, just inject DeclarationDependencyTracker.

I actually have a report locally for the 50 most popular extensions and their gaps where result cache gets stale which could be filled and fixed with these new methods.

I plan to go through it after 2.3.0 release.