pgsql: Don't allocate memory for default arguments #20757
+2
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
reviewed
Dec 21, 2025
| zend_string *table_name; | ||
| zend_string *pg_delimiter = NULL; | ||
| char *pg_null_as = NULL; | ||
| char *pg_null_as = "\\\\N"; |
Member
There was a problem hiding this comment.
Can't you mark this as const 🤔
Suggested change
| char *pg_null_as = "\\\\N"; | |
| const char *pg_null_as = "\\\\N"; |
Also, isn't there potentially an issue if the user defined value contains a nul byte?
Member
Author
There was a problem hiding this comment.
Can't you mark this as const 🤔
No, because the Z_PARAM_STRING API internally calls the zend_parse_arg_string helper that has char **dest.
Also, isn't there potentially an issue if the user defined value contains a nul byte?
Yes
Member
|
looks good, no idea if you want to try gina's suggestion or leave it for another PR eventually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.