phar: Simplify phar_open_archive_fp() #20753
Merged
+24
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By returning the stream directly, we avoid calling some helpers functions and it becomes more clear on what stream the code actually acts upon.
Girgias
approved these changes
Dec 21, 2025
Member
Girgias
left a comment
Girgias
left a comment
There was a problem hiding this comment.
Minor nit but LGTM and it is indeed more obvious what is happenning.
ext/phar/util.c
Outdated
| PHAR_G(cached_fp)[phar->phar_pos].fp = fp; | ||
| } | ||
|
|
||
| /* initialize a phar_archive_data's read-only fp for existing phar data */ |
Member
There was a problem hiding this comment.
Maybe clarify in the comment that the returned stream must not be closed/freed as it is owned by the phar?
Member
Author
There was a problem hiding this comment.
Yeah that's a good call. Done that now.
Girgias
approved these changes
Dec 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By returning the stream directly, we avoid calling some helpers functions and it becomes more clear on what stream the code actually acts upon.