Repository navigation
Conversation
Redirects::renderTo() created the php-web directory and then tried to write the JSON onto that same path, which fails with "Is a directory". Write the file inside the directory and cover renderTo() with a test.
This was referenced Oct 22, 2026
Member
|
Let's merge this in first. So we can get the redirect structure ready. This PR has been reviewed already anyway. |
lacatoire
marked this pull request as ready for review
October 26, 2026 07:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redirects::renderTo()wrote the JSON onto thephp-webdirectory itself ("Is a directory"). Writeredirects.jsoninside it, with a test.Includes #260, which it fixes.
Block: php/doc-extensions#49, php/doc-en#5998, php/doc-fr#3696, php/web-php#2038. Merge order and how to test: php/doc-fr#3696.