feat!: rewrite to use cucumber messages by daantimmer · Pull Request #273 · philips-software/amp-cucumber-cpp-runner

Daan Timmer (daantimmer) · 2025-12-18T23:32:17Z

This (internal) rewrite is to make amp-cucumber-cpp-runner cucumber-messages compatible. Both during runtime and during formatting.

This will enable amp-cucumber-cpp-runner to be compatible with other, standalone, formatters.

… compatibility kit

…r to catch errors

…ta, doc-strings, empty, examples-tables and minimal

…ooks-beforeall-error, hooks, hooks-attachment and hooks-conditional compatibility tests

…ation exists

github-actions · 2025-12-18T23:44:33Z

✅⚠️MegaLinter analysis: Success with warnings

Descriptor	Linter	Files	Fixed	Errors	Warnings	Elapsed time
✅ ACTION	actionlint	6		0	0	0.29s
✅ CPP	clang-format	190	0	0	0	1.64s
✅ DOCKERFILE	hadolint	1		0	0	0.31s
✅ JSON	jsonlint	8		0	0	0.19s
✅ JSON	prettier	8	6	0	0	0.55s
⚠️ MARKDOWN	markdownlint	6	3	14	0	1.09s
✅ MARKDOWN	markdown-table-formatter	6	3	0	0	0.29s
✅ REPOSITORY	git_diff	yes		no	no	0.03s
✅ REPOSITORY	grype	yes		no	no	30.91s
✅ REPOSITORY	ls-lint	yes		no	no	0.07s
✅ REPOSITORY	secretlint	yes		no	no	2.08s
✅ REPOSITORY	syft	yes		no	no	1.22s
✅ REPOSITORY	trivy	yes		no	no	5.62s
✅ REPOSITORY	trivy-sbom	yes		no	no	0.12s
✅ REPOSITORY	trufflehog	yes		no	no	2.17s
⚠️ SPELL	lychee	83		2	0	3.59s
✅ YAML	prettier	10	0	0	0	0.55s
✅ YAML	v8r	10		0	0	4.81s
✅ YAML	yamllint	10		0	0	0.55s

Detailed Issues

⚠️ SPELL / lychee - 2 errors

[ERROR] https://www.conventionalcommits.org/en/v1.0.0/ | Network error: error sending request for url (https://www.conventionalcommits.org/en/v1.0.0/) Maybe a certificate error?
[404] https://github.com/yourname/amp-cucumber-cpp-runner.git | Network error: Not Found
📝 Summary
---------------------
🔍 Total..........155
✅ Successful.....153
⏳ Timeouts.........0
🔀 Redirected.......0
👻 Excluded.........0
❓ Unknown..........0
🚫 Errors...........2

Errors in CONTRIBUTING.md
[404] https://github.com/yourname/amp-cucumber-cpp-runner.git | Network error: Not Found

Errors in .github/workflows/pr-conventional-title.yml
[ERROR] https://www.conventionalcommits.org/en/v1.0.0/ | Network error: error sending request for url (https://www.conventionalcommits.org/en/v1.0.0/) Maybe a certificate error?

⚠️ MARKDOWN / markdownlint - 14 errors

CHANGELOG.md:26 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Chores"]
CHANGELOG.md:38 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Features"]
CHANGELOG.md:47 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Features"]
CHANGELOG.md:53 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Chores"]
CHANGELOG.md:61 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "⚠ BREAKING CHANGES"]
CHANGELOG.md:65 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Features"]
CHANGELOG.md:70 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Bug Fixes"]
CHANGELOG.md:79 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Features"]
CHANGELOG.md:90 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Chores"]
CHANGELOG.md:98 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "⚠ BREAKING CHANGES"]
CHANGELOG.md:102 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Features"]
CHANGELOG.md:127 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Bug Fixes"]
CHANGELOG.md:134 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Chores"]
README.md:114 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

Documentation: Custom Flavors
Command: npx mega-linter-runner@9.3.0 --custom-flavor-setup --custom-flavor-linters ACTION_ACTIONLINT,CPP_CLANG_FORMAT,DOCKERFILE_HADOLINT,JSON_JSONLINT,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_GIT_DIFF,REPOSITORY_GRYPE,REPOSITORY_LS_LINT,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,SPELL_LYCHEE,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

github-actions · 2025-12-18T23:51:59Z

Test Results

27 tests - 1 27 ✅ - 1 27s ⏱️ +23s
1 suites ±0 0 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit 4c33bf8. ± Comparison against base commit 947fe10.

This pull request removes 6 and adds 5 tests. Note that renamed tests count towards both.

test.bats ‑ Missing mandatory feature argument
test.bats ‑ Missing mandatory report argument
test.bats ‑ Second feature file does not overwrite success with an undefined status
test.bats ‑ Test the asterisk keyword - will fail
test.bats ‑ Test unused step reporting
test.bats ‑ Undefined tests

test.bats ‑ Second feature file does not overwrite success with an ■ status
test.bats ‑ Test nested steps
test.bats ‑ Test the asterisk keyword
test.bats ‑ Test usage formatter
test.bats ‑ ■ tests

♻️ This comment has been updated with latest results.

Copilot

Pull request overview

Copilot reviewed 291 out of 381 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…ation calculations

…es and views

Copilot

Pull request overview

Copilot reviewed 291 out of 381 changed files in this pull request and generated 7 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

cucumber_cpp/library/BodyMacro.hpp

compatibility/CMakeLists.txt

cucumber_cpp/library/formatter/test/CMakeLists.txt

CMakePresets.json

cucumber_cpp/library/api/Formatters.cpp

compatibility/regular-expression/regular-expression.cpp

cucumber_cpp/library/formatter/PrettyFormatter.hpp

Copilot · 2026-02-17T10:44:12Z

Daan Timmer (@daantimmer) I've opened a new pull request, #290, to work on those changes. Once the pull request is ready, I'll request review from you.

…_main

…ition

…ncludes

Copilot

Pull request overview

Copilot reviewed 291 out of 383 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

cucumber_cpp/library/cucumber_expression/RegularExpression.hpp

Copilot · 2026-02-17T12:48:12Z

cucumber_cpp/library/engine/Step.hpp

+        StepBase(const runtime::NestedTestCaseRunner& nestedTestCaseRunner, util::Broadcaster& broadCaster, Context& context, engine::StepOrHookStarted stepOrHookStarted, const std::optional<cucumber::messages::pickle_table>& dataTable, const std::optional<cucumber::messages::pickle_doc_string>& docString);
+        virtual ~StepBase() = default;


StepBase stores dataTable and docString as reference members. This makes the type very sensitive to the caller’s lifetimes (passing temporaries will create dangling references). Consider storing these by value (cheap for std::optional wrappers), or storing pointers/std::reference_wrapper with explicit “may be null” semantics, or at least documenting/enforcing that the referenced optionals must outlive the step object.

Copilot · 2026-02-17T12:48:12Z

cucumber_cpp/library/engine/Step.hpp

+        const std::optional<cucumber::messages::pickle_table>& dataTable;
+        const std::optional<cucumber::messages::pickle_doc_string>& docString;


StepBase stores dataTable and docString as reference members. This makes the type very sensitive to the caller’s lifetimes (passing temporaries will create dangling references). Consider storing these by value (cheap for std::optional wrappers), or storing pointers/std::reference_wrapper with explicit “may be null” semantics, or at least documenting/enforcing that the referenced optionals must outlive the step object.

Suggested change

const std::optional<cucumber::messages::pickle_table>& dataTable;

const std::optional<cucumber::messages::pickle_doc_string>& docString;

std::optional<cucumber::messages::pickle_table> dataTable;

std::optional<cucumber::messages::pickle_doc_string> docString;

Copilot · 2026-02-17T12:48:12Z

cucumber_cpp/library/BodyMacro.hpp

+template<class T>
+T TransformArg(const cucumber::messages::step_match_argument& match)
+{
+    return cucumber_cpp::library::cucumber_expression::ConverterTypeMap<T>::Instance().at(match.parameter_type_name.value_or(""))(match.group);
+}


TransformArg is defined in the global namespace in a widely included header, which increases the chance of name collisions and makes ADL/visibility harder to reason about. Consider moving it under a cucumber_cpp::library::detail (or similar) namespace (and keeping it header-only) to reduce symbol pollution.

Copilot · 2026-02-17T12:48:13Z

compatibility/unused-steps/unused-steps.feature

@@ -0,0 +1,6 @@
+Feature: Unused steps
+  Depending on the run, some step definitions may not be used. This is valid, and the step definitions are still
+  includes in the stream of messages, which allows formatters to report on step usage if desired.


Correct the grammar: 'includes' should be 'included' in this sentence.

Suggested change

includes in the stream of messages, which allows formatters to report on step usage if desired.

included in the stream of messages, which allows formatters to report on step usage if desired.

…il namespace

…bility files

Copilot

Pull request overview

Copilot reviewed 291 out of 383 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 291 out of 383 changed files in this pull request and generated 10 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-17T14:22:04Z

cucumber_cpp/library/cucumber_expression/test/TestTransformation.cpp

-#include "cucumber_cpp/library/cucumber_expression/Errors.hpp"
 #include "cucumber_cpp/library/cucumber_expression/Expression.hpp"
 #include "cucumber_cpp/library/cucumber_expression/ParameterRegistry.hpp"
+#include "fmt/format.h"


The header include order should be consistent. Standard library headers (like <string>, <vector>) should come after third-party headers. Consider moving fmt/format.h after the cucumber headers but before standard library headers.

cucumber_cpp/library/cucumber_expression/Expression.hpp

Copilot · 2026-02-17T14:22:05Z

cucumber_cpp/library/formatter/helper/CMakeLists.txt

+
+if (CCR_BUILD_TESTS)
+    add_subdirectory(test)
+    # add_subdirectory(test_helper)


Commented-out code should be removed unless there's a specific reason to keep it. If this is intentionally disabled pending future work, add a TODO comment explaining why.

Suggested change

# add_subdirectory(test_helper)

# TODO: Re-enable helper tests when they are ready: add_subdirectory(test_helper)

Copilot · 2026-02-17T14:22:05Z

cucumber_cpp/library/formatter/CMakeLists.txt

+
+if (CCR_BUILD_TESTS)
+    add_subdirectory(test)
+    # add_subdirectory(test_helper)


Commented-out code should be removed unless there's a specific reason to keep it. If this is intentionally disabled pending future work, add a TODO comment explaining why.

Suggested change

# add_subdirectory(test_helper)

Copilot · 2026-02-17T14:22:05Z

cucumber_cpp/library/engine/CMakeLists.txt

 target_link_libraries(cucumber_cpp.library.engine PUBLIC
-    cucumber_cpp.library
+    base64
+    # cucumber_cpp.library


Commented-out code should be removed unless there's a specific reason to keep it. If this is intentionally disabled pending future work, add a TODO comment explaining why.

Copilot · 2026-02-17T14:22:06Z

cucumber_cpp/library/engine/CMakeLists.txt

 )

 if (CCR_BUILD_TESTS)
    add_subdirectory(test)


Commented-out code should be removed unless there's a specific reason to keep it. If this is intentionally disabled pending future work, add a TODO comment explaining why.

Suggested change

add_subdirectory(test)

add_subdirectory(test)

# TODO: Re-enable test_helper when its tests and dependencies are ready.

Copilot · 2026-02-17T14:22:06Z

cucumber_cpp/library/api/CMakeLists.txt

+
+if (CCR_BUILD_TESTS)
+    add_subdirectory(test)
+    # add_subdirectory(test_helper)


Commented-out code should be removed unless there's a specific reason to keep it. If this is intentionally disabled pending future work, add a TODO comment explaining why.

Suggested change

# add_subdirectory(test_helper)

Copilot · 2026-02-17T14:22:06Z

cucumber_cpp/library/CMakeLists.txt

+add_subdirectory(tag_expression)
 add_subdirectory(util)

 if (CCR_BUILD_TESTS)


Commented-out code should be removed unless there's a specific reason to keep it. If this is intentionally disabled pending future work, add a TODO comment explaining why.

Suggested change

if (CCR_BUILD_TESTS)

if (CCR_BUILD_TESTS)

# TODO: Re-enable the test subdirectory when the test suite is ready to be built with this library.

Copilot · 2026-02-17T14:22:06Z

cucumber_cpp/library/assemble/CMakeLists.txt

+
+if (CCR_BUILD_TESTS)
+    add_subdirectory(test)
+    # add_subdirectory(test_helper)


Commented-out code should be removed unless there's a specific reason to keep it. If this is intentionally disabled pending future work, add a TODO comment explaining why.

Suggested change

# add_subdirectory(test_helper)

Copilot · 2026-02-17T14:22:07Z

cucumber_cpp/library/engine/test/CMakeLists.txt

+    # cucumber_cpp.library.engine.test_helper
+    # cucumber_cpp.library.engine.test_helper.steps


Commented-out code should be removed unless there's a specific reason to keep it. If this is intentionally disabled pending future work, add a TODO comment explaining why.

Suggested change

# cucumber_cpp.library.engine.test_helper

# cucumber_cpp.library.engine.test_helper.steps

…discard]] attributes and restructuring functions

…eeRegexp, and test files

Copilot

Pull request overview

Copilot reviewed 291 out of 395 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…ting logic

sonarqubecloud · 2026-02-25T23:56:13Z

Quality Gate passed

Issues
72 New issues
6 Accepted issues

Measures
0 Security Hotspots
83.0% Coverage on New Code
0.4% Duplication on New Code

See analysis details on SonarQube Cloud

Daan Timmer (daantimmer) added 22 commits December 8, 2025 12:44

feat!: rewrite to use cucumber messages

1457b95

enable ccache

e8e9362

disable the build of shared libs

792332e

disable position independent code generation for jbeder/yaml-cpp

e8c96aa

add additional launch tags

48d99c6

add first version (empty, minimal and data-tables are enabled) of the…

1ae9468

… compatibility kit

refactored a lot of code

10137be

removed unused files

7ac6e9c

update devcontainers for CI

77b4762

removed agauniyal/rang from dependencies

50a2bce

cleanup Application

4054607

sanitize and dump actual and expected json

45a4380

set option variables for dependencies as cache variables

958e05c

fix grouping for string parameter

6eb2da0

use ScopedFakeTestPartResultReporter instead of EmptyTestEventListene…

ece0b62

…r to catch errors

Enable the following compatibility tests: ambiguous, backgrounds, cda…

6f1f4c8

…ta, doc-strings, empty, examples-tables and minimal

add examples-tables-attachment compatibility test

07a77d7

add attachments compatibility test

028dcc5

enabled examples-tables-undefined and global-hooks compatibility test

640986f

Added global-hooks-afterall-error, global-hooks-attachments, global-h…

cbb2f0c

…ooks-beforeall-error, hooks, hooks-attachment and hooks-conditional compatibility tests

add all compatibility checks by default regardless if a cpp implement…

dfe7157

…ation exists

add hooks-named, hooks-skipped and hooks-undefined compatibility tests

de2aaeb

Daan Timmer (daantimmer) mentioned this pull request Dec 18, 2025

feat: ndjson reporting #240

Closed

15 tasks

Daan Timmer (daantimmer) added 2 commits December 18, 2025 23:40

add multiple-features and multiple-features-reverses compatibility tests

d1a3e52

Merge branch 'main' into feature/rewrite-to-use-cucumber-messages

cad1bcf

Daan Timmer (daantimmer) added 3 commits December 19, 2025 09:46

fix clang-msvc build

83c6e5a

fix clang-msvc build

13484a5

fix MSVC build

c7ee029

Copilot AI reviewed Feb 16, 2026

View reviewed changes

Daan Timmer (daantimmer) added 2 commits February 16, 2026 14:09

refactor: enhance UsageFormatter with structured mapping and mean dur…

ac8cb60

…ation calculations

refactor: optimize duration calculations in UsageFormatter using rang…

c7a71f2

…es and views

Copilot AI review requested due to automatic review settings February 16, 2026 14:25

Copilot AI reviewed Feb 16, 2026

View reviewed changes

Copilot AI mentioned this pull request Feb 17, 2026

Close stacked PR - CLI11 validation prevents invalid formatter names #290

Closed

Daan Timmer (daantimmer) and others added 5 commits February 17, 2026 12:00

Merge branch 'main' into feature/rewrite-to-use-cucumber-messages

18696d8

refactor: update CMakeLists to use GTest::gmock_main instead of gmock…

eb195e1

…_main

fix: correct spelling of 'vegetable' in regular-expression step defin…

2741a85

…ition

refactor: rename PrettyPrinter to PrettyFormatter and remove unused i…

90a00f5

…ncludes

Removed StringTo.hpp

56c31f9

Copilot AI review requested due to automatic review settings February 17, 2026 12:44

Copilot AI reviewed Feb 17, 2026

View reviewed changes

Daan Timmer (daantimmer) added 2 commits February 17, 2026 12:53

refactor: move TransformArg function into cucumber_cpp::library::deta…

75ca34c

…il namespace

refactor: replace json_fwd.hpp with json.hpp in formatter and compati…

d43247a

…bility files

Copilot AI review requested due to automatic review settings February 17, 2026 14:14

Copilot AI reviewed Feb 17, 2026

View reviewed changes

Daan Timmer (daantimmer) added 2 commits February 17, 2026 14:19

docs: add note on assertion behavior in amp-cucumber-cpp-runner

ab945a5

docs: add note on quoting tags for Windows users in README.md

4b8cfb4

Copilot AI review requested due to automatic review settings February 17, 2026 14:20

Copilot AI reviewed Feb 17, 2026

View reviewed changes

Daan Timmer (daantimmer) added 4 commits February 18, 2026 09:07

fix clang-tidy configuration file

ab2546a

refactor: enhance code readability and maintainability by adding [[no…

dfef9ca

…discard]] attributes and restructuring functions

add unit tests for cucumber_expression RegularExpressions

8255af5

refactor: remove unused includes from Argument, ParameterRegistry, Tr…

25a7982

…eeRegexp, and test files

Copilot AI review requested due to automatic review settings February 19, 2026 16:00

Copilot AI reviewed Feb 19, 2026

View reviewed changes

refactor: change SortMappedByRegex return type to bool and update sor…

4c33bf8

…ting logic

		StepBase(const runtime::NestedTestCaseRunner& nestedTestCaseRunner, util::Broadcaster& broadCaster, Context& context, engine::StepOrHookStarted stepOrHookStarted, const std::optional<cucumber::messages::pickle_table>& dataTable, const std::optional<cucumber::messages::pickle_doc_string>& docString);
		virtual ~StepBase() = default;

		const std::optional<cucumber::messages::pickle_table>& dataTable;
		const std::optional<cucumber::messages::pickle_doc_string>& docString;

	includes in the stream of messages, which allows formatters to report on step usage if desired.
	included in the stream of messages, which allows formatters to report on step usage if desired.

	# add_subdirectory(test_helper)
	# TODO: Re-enable helper tests when they are ready: add_subdirectory(test_helper)

	add_subdirectory(test)
	add_subdirectory(test)
	# TODO: Re-enable test_helper when its tests and dependencies are ready.

	if (CCR_BUILD_TESTS)
	if (CCR_BUILD_TESTS)
	# TODO: Re-enable the test subdirectory when the test suite is ready to be built with this library.

		# cucumber_cpp.library.engine.test_helper
		# cucumber_cpp.library.engine.test_helper.steps

Conversation

Daan Timmer (daantimmer) commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅⚠️MegaLinter analysis: Success with warnings

Detailed Issues

Uh oh!

github-actions bot commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Feb 17, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Daan Timmer (daantimmer) commented Dec 18, 2025 •

edited

Loading

github-actions bot commented Dec 18, 2025 •

edited

Loading

github-actions bot commented Dec 18, 2025 •

edited

Loading