fix: use loop variable col[:class] instead of assign @col[:class] in table component#164
Merged
Merged
Conversation
… table component Agent-Logs-Url: https://github.com/georgemarshall/daisy_ui_components/sessions/7bd3ea50-2601-493e-a4bf-0301e71e6885 Co-authored-by: georgemarshall <132688+georgemarshall@users.noreply.github.com>
Agent-Logs-Url: https://github.com/georgemarshall/daisy_ui_components/sessions/e287431e-922c-48f4-948c-de9bc0d1900e Co-authored-by: georgemarshall <132688+georgemarshall@users.noreply.github.com>
phcurado
approved these changes
Apr 5, 2026
Owner
|
awesome, thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes a bug in the
DaisyUIComponents.Tablecomponent where the column-specific class was not being correctly applied to table cells. It also updates the tests to verify that the class is now properly set on the rendered cells.Component bug fix:
classassignment in the table cell rendering to use the current column's class (col[:class]) instead of referencing the column definition list (@col[:class]). This ensures that column-specific classes are correctly applied to each cell.Test improvements:
class="col-id"attribute to the "id" column, ensuring that the test checks for the correct application of the class.col-idclass for both rows, confirming that the fix works as intended. [1] [2]