Skip to content

Fix pr 13 removed the nil check from AVLTree >> add: entirely#31

Merged
jordanmontt merged 2 commits intopharo-containers:mainfrom
pankaj-bind:fix-pr-13
Mar 27, 2025
Merged

Fix pr 13 removed the nil check from AVLTree >> add: entirely#31
jordanmontt merged 2 commits intopharo-containers:mainfrom
pankaj-bind:fix-pr-13

Conversation

@pankaj-bind
Copy link
Contributor

PR #13 issue

@jordanmontt I have removed the nil check from AVLTree >> add: entirely

Now,
Modify CTAVLTree.class.st

Before

{ #category : 'adding' }
CTAVLTree >> add: newObject [
    newObject ifNil: [ Error signal: 'Cannot add nil to AVLTree' ].
    root := root addChild: newObject.
    ^ newObject
]

After

{ #category : 'adding' }
CTAVLTree >> add: newObject [
    root := root addChild: newObject.
    ^ newObject
]

@jordanmontt jordanmontt merged commit 560111b into pharo-containers:main Mar 27, 2025
1 check passed
@pankaj-bind pankaj-bind changed the title Fix pr 13 Fix pr 13 removed the nil check from AVLTree >> add: entirely Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants