Postgres images containing Spock 6.0.0 beta1#24
Conversation
📝 WalkthroughWalkthroughThis PR adds amd64 and arm64 package lists for PostgreSQL 16.14, 17.10, and 18.4 with Spock 6.0.0-beta1, adds matching image build entries, and updates the test runner to derive and verify the expected Spock major version. ChangesSpock 6.0.0-beta1 Package Lists
Image Build Wiring and Version-Aware Testing
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
There was a problem hiding this comment.
🧹 Nitpick comments (1)
tests/main.go (1)
189-189: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value
buildTestSuite(spockMajor)is built twice per run.
runExtensionTestsandprintSummaryeach independently callbuildTestSuite(spockMajor)to get the same test list — once to run tests, once just to count them for the summary. Consider computing the suite once inmain()and passing it to both functions to avoid rebuilding it.Also applies to: 198-199
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/main.go` at line 189, `buildTestSuite(spockMajor)` is being recomputed multiple times for the same run. Update `main()`, `runExtensionTests`, and `printSummary` so the suite is built once and passed through to both consumers instead of calling `buildTestSuite(spockMajor)` independently. Use the existing `buildTestSuite` symbol and the `runExtensionTests`/`printSummary` call sites to thread the cached suite into both paths.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@tests/main.go`:
- Line 189: `buildTestSuite(spockMajor)` is being recomputed multiple times for
the same run. Update `main()`, `runExtensionTests`, and `printSummary` so the
suite is built once and passed through to both consumers instead of calling
`buildTestSuite(spockMajor)` independently. Use the existing `buildTestSuite`
symbol and the `runExtensionTests`/`printSummary` call sites to thread the
cached suite into both paths.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: ca5b5e9d-38d1-43d2-9da0-a7792cff7193
📒 Files selected for processing (14)
packagelists/amd64/pg16.14-spock6.0.0-beta1-minimal.txtpackagelists/amd64/pg16.14-spock6.0.0-beta1-standard.txtpackagelists/amd64/pg17.10-spock6.0.0-beta1-minimal.txtpackagelists/amd64/pg17.10-spock6.0.0-beta1-standard.txtpackagelists/amd64/pg18.4-spock6.0.0-beta1-minimal.txtpackagelists/amd64/pg18.4-spock6.0.0-beta1-standard.txtpackagelists/arm64/pg16.14-spock6.0.0-beta1-minimal.txtpackagelists/arm64/pg16.14-spock6.0.0-beta1-standard.txtpackagelists/arm64/pg17.10-spock6.0.0-beta1-minimal.txtpackagelists/arm64/pg17.10-spock6.0.0-beta1-standard.txtpackagelists/arm64/pg18.4-spock6.0.0-beta1-minimal.txtpackagelists/arm64/pg18.4-spock6.0.0-beta1-standard.txtscripts/build_pgedge_images.pytests/main.go
Uh oh!
There was an error while loading. Please reload this page.