Skip to content

Compile on windows msys2#10

Draft
masoudd wants to merge 4 commits into
persiancal:masterfrom
masoudd:msys2_windows
Draft

Compile on windows msys2#10
masoudd wants to merge 4 commits into
persiancal:masterfrom
masoudd:msys2_windows

Conversation

@masoudd

@masoudd masoudd commented Jun 14, 2024

Copy link
Copy Markdown

This PR adds a "strptime.c" stub and some small changes to make it compile on MSYS2 (mingw64).

Any input is appreciated.

masoudd added 4 commits June 14, 2024 11:06
The strptime function is not available on windows in msys2
environment.
As stated in `man 3type tm` we need to define _DEFAULT_SOURCE for access
to `tm_gmtoff` and `tm_zone` (since glib 2.20)
@mohsenkhanpour

mohsenkhanpour commented Mar 30, 2025

Copy link
Copy Markdown

@masoudd Thanks, I have built your fork on MSYS2 and it has been working without issue.
A suggestion would be also publishing to MSYS2 packages repo for ease of access.
https://packages.msys2.org/repos

Since there is also effort to create a build pipeline, artifacts can also be published to winget and scoop 26469c64246358de40659dcca603bd5bf87ccc2d

@fzerorubigd I could build this on MSYS2, do you think merging would cause issue with Linux builds?

@masoudd

masoudd commented Mar 30, 2025

Copy link
Copy Markdown
Author

A suggestion would be also publishing to MSYS2 packages repo for ease of access.

Yes. That's a good idea. I'll look into it

I could build this on MSYS2, do you think merging would cause issue with Linux builds?

I've been testing this on linux as well and it seems to be working. The goal is to not change any process for linux, just add functionality for msys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants