Add Cloud PDP benchmarks documentation#624
Merged
omer9564 merged 4 commits intoJun 16, 2026
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for permitio-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new documentation page describing Cloud PDP performance benchmarks and links it from the PDP section in the docs sidebar.
Changes:
- Added a new Cloud PDP Benchmarks MDX page with RBAC/ReBAC latency and throughput tables.
- Linked the new page under The Policy Decision Point (PDP) in the docs sidebar.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
sidebars.js |
Adds the new Cloud PDP benchmarks doc to the PDP sidebar section. |
docs/concepts/pdp/cloud-pdp-benchmarks.mdx |
Introduces benchmark results and key takeaways for Cloud PDP performance. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
zeevmoney
reviewed
Jun 2, 2026
zeevmoney
left a comment
zeevmoney
left a comment
Contributor
There was a problem hiding this comment.
This is an automated review. See comments.
zeevmoney
approved these changes
Jun 15, 2026
zeevmoney
left a comment
zeevmoney
left a comment
Contributor
There was a problem hiding this comment.
Approved ✅ — with comments to address before merge
Thanks @omer9564 — the page is a solid addition and the data tables are internally consistent. Approving so this isn't blocked, but please look over the review comments first.
Please see the inline comments, address them, and then merge. A few are worth a quick pass:
- [MEDIUM] Add a short methodology note (line 10) — date, regions, endpoint, payload, policy size, and the load model. The throughput figures reflect the load generator's offered rate (~paced), not the PDP's capacity, so it's worth saying so explicitly.
- [MEDIUM] The Depth 2/3 scenarios (lines 76–94) reference
DriveandCommentresources that don't appear in thecloud-pdpReBAC fixtures, and I couldn't trace these numbers to any benchmark script in that repo — please confirm the schema/source and ideally link the tooling. - [MEDIUM] Soften "Throughput scales linearly" (line 111) and [LOW] fix the mean-vs-P50 wording (line 110).
- [LOW] Depth 2/3 are missing the single-concurrency tables that RBAC and Depth 1 have (line 76).
None of these block the doc from going live — they're accuracy/clarity improvements. Fix them up and merge when you're happy. 🚀
- Add a Methodology section (date, region, server-side metric source, load notes) - Correct latency description: server-side processing time, not network round-trip - Reword P50 takeaway to a single statistic (mean vs P50 conflation) - Soften "throughput scales linearly" to "near-linearly" - Note why Depth 2/3 show only the 10-concurrent case Addresses review comments: - #624 (comment) (@copilot-pull-request-reviewer) - #624 (comment) (@copilot-pull-request-reviewer) - #624 (comment) (@copilot-pull-request-reviewer) - #624 (comment) (@zeevmoney) - #624 (comment) (@zeevmoney) - #624 (comment) (@zeevmoney) - #624 (comment) (@zeevmoney) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
omer9564
deleted the
omer/per-14545-upload-cloud-pdp-benchmarks-to-the-docs
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code