Conversation
There was a problem hiding this comment.
Pull request overview
Removes the legacy jline:jline 0.9.94 dependency from the build and the plugin assembly so the Big Data Plugin no longer declares or bundles an outdated, unused library.
Changes:
- Removed
dependency.jline.revisionfrom the rootpom.xml. - Removed direct
jline:jlinedependencies from legacy module POMs and the main assembly POM. - Removed
jline:jlinefrom the plugin assembly include list (plugin.xml).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
pom.xml |
Drops the root property for the jline version. |
legacy/pom.xml |
Removes the jline version property and the explicit jline dependency. |
legacy-amazon/core/pom.xml |
Removes the jline version property and the explicit jline dependency. |
assemblies/pentaho-big-data-plugin/src/main/assembly/descriptors/plugin.xml |
Stops bundling jline:jline in the plugin assembly includes. |
assemblies/pentaho-big-data-plugin/pom.xml |
Removes the explicit jline:jline dependency from the assembly module. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
Note:Frogbot also supports Contextual Analysis, Secret Detection, IaC and SAST Vulnerabilities Scanning. This features are included as part of the JFrog Advanced Security package, which isn't enabled on your system. |
Collaborator
✅ Build finished in 7m 31sBuild command: mvn clean verify -B -e -Daudit -Djs.no.sandbox👌 All tests passed! Tests run: 1116, Failures: 0, Skipped: 17 Test Results ℹ️ This is an automatic message |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@pentaho/tatooine_dev