chore: clean up wof dictionary generation code#132
Open
missinglink wants to merge 2 commits intomasterfrom
Open
chore: clean up wof dictionary generation code#132missinglink wants to merge 2 commits intomasterfrom
missinglink wants to merge 2 commits intomasterfrom
Conversation
Member
Author
Member
|
Should we also normalize names here ? I found some name with uppercase and accents like Second thought : Adding normalization will not improve diff reading, so I will merge as-is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

I attempted to update the WOF resources today but lost enthusiasm half way through due to a bunch of different changes popping up.
This PR makes subsequent attempts at updating WOF considerably easier:
this should be a no-op, it's only sorting existing dictionaries, not adding or removing from them.