Skip to content

Fix snapshot streaming download progress#25331

Open
decofe wants to merge 1 commit into
mainfrom
centaur/1781625056-1522-8012
Open

Fix snapshot streaming download progress#25331
decofe wants to merge 1 commit into
mainfrom
centaur/1781625056-1522-8012

Conversation

@decofe

@decofe decofe commented Jun 16, 2026

Copy link
Copy Markdown
Member

Summary

  • make the shared streaming download reader update active logical download bytes
  • roll back active bytes when a streaming attempt ends
  • add a focused unit test for the aggregate progress counters

Prompted by: @SuperFluffy

Test

  • cargo test -p reth-cli-commands download::progress::tests::shared_progress_reader_tracks_active_download_bytes

@github-actions

Copy link
Copy Markdown
Contributor

Your PR title doesn't follow the Conventional Commit guidelines.

Example of valid titles:

  • feat: add new user login
  • fix: correct button size
  • docs: update README

Usage:

  • feat: Introduces a new feature
  • fix: Patches a bug
  • chore: General maintenance tasks or updates
  • test: Adding new tests or modifying existing tests
  • bench: Adding new benchmarks or modifying existing benchmarks
  • perf: Performance improvements
  • refactor: Changes to improve code structure
  • docs: Documentation updates
  • ci: Changes to CI/CD configurations
  • revert: Reverts a previously merged PR
  • deps: Updates dependencies

Breaking Changes

Breaking changes are noted by using an exclamation mark. For example:

  • feat!: changed the API
  • chore(node)!: Removed unused public function

Help

For more information, follow the guidelines here: https://www.conventionalcommits.org/en/v1.0.0/

@github-actions github-actions Bot added the S-stale This issue/PR is stale and will close with no further activity label Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-stale This issue/PR is stale and will close with no further activity

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

1 participant