ENH: clarify error message when getting slice bounds for a non-monotonic index without specifying the label #63397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natmokval
added
Indexing
3 tasks
rhshadrach
requested changes
Dec 17, 2025
Comment on lines
+6873
to
+6874
| f"with a non-specific label: {original_label!r}. " | ||
| "Please specify the label." |
Member
There was a problem hiding this comment.
Suggested change
| f"with a non-specific label: {original_label!r}. " | |
| "Please specify the label." | |
| f"with a missing label {original_label!r}. " | |
| "Either sort the index or specify an existing label." |
It's not clear to me what "non-specific" here means.
| f"Cannot get {side} slice bound for non-monotonic index " | ||
| f"with a non-specific label: {original_label!r}. " | ||
| "Please specify the label." | ||
| ) from err |
Member
There was a problem hiding this comment.
I think this should remain
Suggested change
| ) from err | |
| ) from None |
We know that it's due to a missing label, adding the previous stack trace does not help clarify the error for the user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.