BUG: fix empty suffix and prefix handling in pyarrow string methods #63395
+18
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python's `str.removeprefix("")` and `str.removesuffix("")` return the
original string.
The current pyarrow-backed implementation slices with `stop=0` or
`start=0` when the prefix or suffix is empty, which can result in
unexpected behavior instead of preserving the original values.
This PR adds explicit guards for empty prefix and suffix inputs and
includes tests to ensure parity with Python semantics.
Member
|
@vkverma9534 Thanks for the catch and for the PR! Could you add a test for this case? There is an existing test |
jorisvandenbossche
added
Strings
Author
|
Added explicit handling for empty prefix and suffix and added regression tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python's
str.removeprefix("")andstr.removesuffix("")return the original string.The current pyarrow-backed implementation slices with
stop=0orstart=0when the prefix or suffix is empty, which can result in unexpected behavior instead of preserving the original values.This PR adds explicit guards for empty prefix and suffix inputs and includes tests to ensure parity with Python semantics.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.AGENTS.md.