Type generic.pyi
#1562
Type generic.pyi
#1562
Conversation
MarcoGorelli
force-pushed
the
typ-generic
branch
from
3009ab9 to
8717b4d
Compare
loicdiridollou
left a comment
loicdiridollou
left a comment
There was a problem hiding this comment.
One minor thing but then should be good.
pandas-stubs/core/generic.pyi
Outdated
| def drop( | ||
| self, | ||
| labels=..., | ||
| labels: Hashable | Sequence[Hashable] | Index | None = None, |
There was a problem hiding this comment.
I think we should be able to put range here too, docs says single label or iterable of labels so range should fit, maybe ListLike would be a slightly wider type.
| if sys.version_info >= (3, 11): | ||
| def __array__( | ||
| self, dtype: _str | np.dtype = ..., copy: bool | None = ... | ||
| ) -> np_1darray: ... | ||
| else: | ||
| def __array__( | ||
| self, dtype: _str | np.dtype[Any] = ..., copy: bool | None = ... | ||
| ) -> np_1darray: ... | ||
|
|
There was a problem hiding this comment.
Please keep it, it is needed for the pyright strict transition.
There was a problem hiding this comment.
is it ok to handle this within NpDType?
There was a problem hiding this comment.
NpDtype is different from str | np.dtype. It will take a separate PR to handle, I think.
cmp0xff
left a comment
cmp0xff
left a comment
There was a problem hiding this comment.
I will leave the PR to @loicdiridollou since he has alread started reviewing. I just wanted to point out the np.dtype issue.
pandas-stubs/core/generic.pyi
Outdated
| def drop( | ||
| self, | ||
| labels=..., | ||
| labels: Hashable | ListLike | None = None, |
There was a problem hiding this comment.
| labels: Hashable | ListLike | None = None, | |
| labels: Hashable | ListLike = None, |
None ia also Hashable. Also applies to other cases in the changes.
3 participants
assert_type()to assert the type of any return value)AGENTS.md.