Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/itsdangerous/serializer.py
Original file line number Diff line number Diff line change
Expand Up @@ -325,9 +325,7 @@ def dump(self, obj: t.Any, f: t.IO[t.Any], salt: str | bytes | None = None) -> N
"""
f.write(self.dumps(obj, salt))

def loads(
self, s: str | bytes, salt: str | bytes | None = None, **kwargs: t.Any
) -> t.Any:
def loads(self, s: str | bytes, salt: str | bytes | None = None) -> t.Any:
"""Reverse of :meth:`dumps`. Raises :exc:`.BadSignature` if the
signature validation fails.
"""
Expand Down
7 changes: 7 additions & 0 deletions tests/test_itsdangerous/test_serializer.py
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,13 @@ def value(self):
def test_serializer(self, serializer: Serializer, value: Any):
assert serializer.loads(serializer.dumps(value)) == value

def test_loads_rejects_max_age(self):
serializer = Serializer("secret_key")
signed = serializer.dumps("value")

with pytest.raises(TypeError):
serializer.loads(signed, max_age=-1) # type: ignore[call-arg]

@pytest.mark.parametrize(
"transform",
(
Expand Down
7 changes: 7 additions & 0 deletions tests/test_itsdangerous/test_url_safe.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,13 @@ def serializer_factory(self):
def value(self, request):
return request.param

def test_loads_rejects_max_age(self):
serializer = URLSafeSerializer("secret-key")
signed = serializer.dumps("value")

with pytest.raises(TypeError):
serializer.loads(signed, max_age=-1) # type: ignore[call-arg]


class TestURLSafeTimedSerializer(TestURLSafeSerializer, TestTimedSerializer):
@pytest.fixture()
Expand Down
Loading