reject empty oauth2 state#567
Merged
bulldozer-bot[bot] merged 1 commit intoJun 15, 2026
Merged
Conversation
Member
|
Thanks for your interest in palantir/go-githubapp, @christophm-pal! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
Generate changelog in
|
✅ Successfully generated changelog entry!Need to regenerate?Simply interact with the changelog bot comment again to regenerate these entries. 📋Changelog Preview🐛 Fixes
|
christophm-pal
force-pushed
the
christophm/reject-empty-state
branch
from
95375c8 to
d1939de
Compare
asvoboda
approved these changes
Jun 15, 2026
asvoboda
left a comment
asvoboda
left a comment
Member
There was a problem hiding this comment.
Thanks for also adding the test case to avoid future regressions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR
An empty OAuth2 state was not rejected by
VerifyState.After this PR
==COMMIT_MSG==
==COMMIT_MSG==
Possible downsides?