Open
Conversation
cheb0
changed the title
Contributor
🔴 Performance DegradationSome benchmarks have degraded compared to the previous run. Show table
|
Contributor
🔴 Performance DegradationSome benchmarks have degraded compared to the previous run. Show table
|
dkharms
reviewed
Feb 20, 2026
| logger.Warn("slow search", | ||
| zap.Int64("took_ms", took.Milliseconds()), | ||
| zap.Object("req", (*searchRequestMarshaler)(req)), | ||
| zap.String("type", searchParams.Type()), |
Member
There was a problem hiding this comment.
Maybe we can move this log inside Searcher.SearchDocs method and enrich log with more information (as we discussed):
time_rangein seconds?fractionswith list of all fraction names (without.docs/.meta/.indexextensions) that were touched by search request;
And it seems like searchRequestMarshaler uses deprecated fields for aggregations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Very simple fix to allow searching slow search request by type.